* [PATCH v2] async: Let kfree() out of the critical area of the lock
@ 2019-09-27 6:03 Yunfeng Ye
2019-10-11 8:11 ` Yunfeng Ye
0 siblings, 1 reply; 4+ messages in thread
From: Yunfeng Ye @ 2019-09-27 6:03 UTC (permalink / raw)
To: Bart Van Assche, dsterba, bhelgaas, tglx, Alexander Duyck,
sakari.ailus, gregkh, David Sterba
Cc: linux-kernel
The async_lock is big global lock, and kfree() is not always cheap, it
will increase lock contention. it's better let kfree() outside the lock
to keep the critical area as short as possible.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
---
v1 -> v2:
- update the description
- add "Reviewed-by"
kernel/async.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/async.c b/kernel/async.c
index 4f9c1d6..1de270d 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -135,12 +135,12 @@ static void async_run_entry_fn(struct work_struct *work)
list_del_init(&entry->domain_list);
list_del_init(&entry->global_list);
- /* 3) free the entry */
- kfree(entry);
atomic_dec(&entry_count);
-
spin_unlock_irqrestore(&async_lock, flags);
+ /* 3) free the entry */
+ kfree(entry);
+
/* 4) wake up any waiters */
wake_up(&async_done);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] async: Let kfree() out of the critical area of the lock
2019-09-27 6:03 [PATCH v2] async: Let kfree() out of the critical area of the lock Yunfeng Ye
@ 2019-10-11 8:11 ` Yunfeng Ye
2019-11-15 18:32 ` Thomas Gleixner
0 siblings, 1 reply; 4+ messages in thread
From: Yunfeng Ye @ 2019-10-11 8:11 UTC (permalink / raw)
To: Bart Van Assche, dsterba, bhelgaas, tglx, Alexander Duyck,
sakari.ailus, gregkh, David Sterba
Cc: linux-kernel
The async_lock is big global lock, and kfree() is not always cheap, it
will increase lock contention. it's better let kfree() outside the lock
to keep the critical area as short as possible.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
---
v1 -> v2:
- update the description
- add "Reviewed-by"
kernel/async.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/async.c b/kernel/async.c
index 4f9c1d6..1de270d 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -135,12 +135,12 @@ static void async_run_entry_fn(struct work_struct *work)
list_del_init(&entry->domain_list);
list_del_init(&entry->global_list);
- /* 3) free the entry */
- kfree(entry);
atomic_dec(&entry_count);
-
spin_unlock_irqrestore(&async_lock, flags);
+ /* 3) free the entry */
+ kfree(entry);
+
/* 4) wake up any waiters */
wake_up(&async_done);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] async: Let kfree() out of the critical area of the lock
2019-10-11 8:11 ` Yunfeng Ye
@ 2019-11-15 18:32 ` Thomas Gleixner
2019-11-19 3:01 ` Yunfeng Ye
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2019-11-15 18:32 UTC (permalink / raw)
To: Yunfeng Ye
Cc: Bart Van Assche, dsterba, bhelgaas, Alexander Duyck,
sakari.ailus, gregkh, David Sterba, linux-kernel
On Fri, 11 Oct 2019, Yunfeng Ye wrote:
> The async_lock is big global lock, and kfree() is not always cheap, it
> will increase lock contention. it's better let kfree() outside the lock
> to keep the critical area as short as possible.
>
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> ---
> v1 -> v2:
> - update the description
> - add "Reviewed-by"
>
> kernel/async.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/async.c b/kernel/async.c
> index 4f9c1d6..1de270d 100644
> --- a/kernel/async.c
> +++ b/kernel/async.c
> @@ -135,12 +135,12 @@ static void async_run_entry_fn(struct work_struct *work)
> list_del_init(&entry->domain_list);
> list_del_init(&entry->global_list);
>
> - /* 3) free the entry */
> - kfree(entry);
> atomic_dec(&entry_count);
> -
> spin_unlock_irqrestore(&async_lock, flags);
>
> + /* 3) free the entry */
> + kfree(entry);
> +
> /* 4) wake up any waiters */
> wake_up(&async_done);
The wakeup should happen before the kfree() for the very same reasons.
Thanks,
tglx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] async: Let kfree() out of the critical area of the lock
2019-11-15 18:32 ` Thomas Gleixner
@ 2019-11-19 3:01 ` Yunfeng Ye
0 siblings, 0 replies; 4+ messages in thread
From: Yunfeng Ye @ 2019-11-19 3:01 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Bart Van Assche, dsterba, bhelgaas, Alexander Duyck,
sakari.ailus, gregkh, David Sterba, linux-kernel, hushiyuan,
linfeilong
On 2019/11/16 2:32, Thomas Gleixner wrote:
>
>
> On Fri, 11 Oct 2019, Yunfeng Ye wrote:
>
>> The async_lock is big global lock, and kfree() is not always cheap, it
>> will increase lock contention. it's better let kfree() outside the lock
>> to keep the critical area as short as possible.
>>
>> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
>> Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>> ---
>> v1 -> v2:
>> - update the description
>> - add "Reviewed-by"
>>
>> kernel/async.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/async.c b/kernel/async.c
>> index 4f9c1d6..1de270d 100644
>> --- a/kernel/async.c
>> +++ b/kernel/async.c
>> @@ -135,12 +135,12 @@ static void async_run_entry_fn(struct work_struct *work)
>> list_del_init(&entry->domain_list);
>> list_del_init(&entry->global_list);
>>
>> - /* 3) free the entry */
>> - kfree(entry);
>> atomic_dec(&entry_count);
>> -
>> spin_unlock_irqrestore(&async_lock, flags);
>>
>> + /* 3) free the entry */
>> + kfree(entry);
>> +
>> /* 4) wake up any waiters */
>> wake_up(&async_done);
>
> The wakeup should happen before the kfree() for the very same reasons.
>
ok, I will modify as your suggest, thanks.
> Thanks,
>
> tglx
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-19 3:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 6:03 [PATCH v2] async: Let kfree() out of the critical area of the lock Yunfeng Ye
2019-10-11 8:11 ` Yunfeng Ye
2019-11-15 18:32 ` Thomas Gleixner
2019-11-19 3:01 ` Yunfeng Ye
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).