From: Anand Jain <anand.jain@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>,
clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static
Date: Thu, 17 Sep 2020 09:47:24 +0800 [thread overview]
Message-ID: <9d4c2521-338a-8bce-46a7-b48818ddad66@oracle.com> (raw)
In-Reply-To: <20200916142604.37744-1-yuehaibing@huawei.com>
On 16/9/20 10:26 pm, YueHaibing wrote:
> Fix sparse warning:
>
> fs/btrfs/sysfs.c:1386:5: warning:
> symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?
misc-next branch has it declared static. It was fixed later.
Thanks, Anand
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/btrfs/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
> index e7b0e10685d9..279d9262b676 100644
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -1383,7 +1383,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
> return ret;
> }
>
> -int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
> +static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
> {
> int ret;
> struct btrfs_device *device;
>
next prev parent reply other threads:[~2020-09-17 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 14:26 [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static YueHaibing
2020-09-17 1:47 ` Anand Jain [this message]
2020-09-17 12:53 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d4c2521-338a-8bce-46a7-b48818ddad66@oracle.com \
--to=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).