* [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static
@ 2020-09-16 14:26 YueHaibing
2020-09-17 1:47 ` Anand Jain
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-09-16 14:26 UTC (permalink / raw)
To: clm, josef, dsterba, anand.jain; +Cc: linux-btrfs, linux-kernel, YueHaibing
Fix sparse warning:
fs/btrfs/sysfs.c:1386:5: warning:
symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/btrfs/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index e7b0e10685d9..279d9262b676 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -1383,7 +1383,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
return ret;
}
-int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
+static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
{
int ret;
struct btrfs_device *device;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static
2020-09-16 14:26 [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static YueHaibing
@ 2020-09-17 1:47 ` Anand Jain
2020-09-17 12:53 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Anand Jain @ 2020-09-17 1:47 UTC (permalink / raw)
To: YueHaibing, clm, josef, dsterba; +Cc: linux-btrfs, linux-kernel
On 16/9/20 10:26 pm, YueHaibing wrote:
> Fix sparse warning:
>
> fs/btrfs/sysfs.c:1386:5: warning:
> symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?
misc-next branch has it declared static. It was fixed later.
Thanks, Anand
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/btrfs/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
> index e7b0e10685d9..279d9262b676 100644
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -1383,7 +1383,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
> return ret;
> }
>
> -int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
> +static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
> {
> int ret;
> struct btrfs_device *device;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static
2020-09-17 1:47 ` Anand Jain
@ 2020-09-17 12:53 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2020-09-17 12:53 UTC (permalink / raw)
To: Anand Jain; +Cc: YueHaibing, clm, josef, dsterba, linux-btrfs, linux-kernel
On Thu, Sep 17, 2020 at 09:47:24AM +0800, Anand Jain wrote:
>
>
>
> On 16/9/20 10:26 pm, YueHaibing wrote:
> > Fix sparse warning:
> >
> > fs/btrfs/sysfs.c:1386:5: warning:
> > symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?
>
>
> misc-next branch has it declared static. It was fixed later.
Yeah it's fixed, the k.org for-next got a bit behind the snapshot
branches, I'll do an update today.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-17 12:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 14:26 [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static YueHaibing
2020-09-17 1:47 ` Anand Jain
2020-09-17 12:53 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).