From: Jens Axboe <axboe@kernel.dk>
To: Will Deacon <will.deacon@arm.com>, Michael Ellerman <mpe@ellerman.id.au>
Cc: Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rich Felker <dalias@libc.org>,
"David S . Miller" <davem@davemloft.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Firoz Khan <firoz.khan@linaro.org>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere
Date: Wed, 3 Apr 2019 07:49:26 -0600 [thread overview]
Message-ID: <9d673dfd-0051-3676-653e-6376430d73dd@kernel.dk> (raw)
In-Reply-To: <20190403111134.GA7159@fuggles.cambridge.arm.com>
On 4/3/19 5:11 AM, Will Deacon wrote:
> Hi Michael,
>
> On Wed, Apr 03, 2019 at 01:47:50PM +1100, Michael Ellerman wrote:
>> Arnd Bergmann <arnd@arndb.de> writes:
>>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl
>>> index b18abb0c3dae..00f5a63c8d9a 100644
>>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl
>>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl
>>> @@ -505,3 +505,7 @@
>>> 421 32 rt_sigtimedwait_time64 sys_rt_sigtimedwait compat_sys_rt_sigtimedwait_time64
>>> 422 32 futex_time64 sys_futex sys_futex
>>> 423 32 sched_rr_get_interval_time64 sys_sched_rr_get_interval sys_sched_rr_get_interval
>>> +424 common pidfd_send_signal sys_pidfd_send_signal
>>> +425 common io_uring_setup sys_io_uring_setup
>>> +426 common io_uring_enter sys_io_uring_enter
>>> +427 common io_uring_register sys_io_uring_register
>>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
>>
>> Lightly tested.
>>
>> The pidfd_test selftest passes.
>
> That reports pass for me too, although it fails to unshare the pid ns, which I
> assume is benign.
>
>> Ran the io_uring example from fio, which prints lots of:
>
> How did you invoke that? I had a play with the tests in:
It's t/io_uring from the fio repo:
git://git.kernel.dk/fio
and you just run it ala:
# make t/io_uring
# t/io_uring /dev/some_device
> git://git.kernel.dk/liburing
>
> but I quickly ran into the kernel oops below.
>
> Will
>
> --->8
>
> will@autoplooker:~/liburing/test$ ./io_uring_register
> RELIMIT_MEMLOCK: 67108864 (67108864)
> [ 35.477875] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000070
> [ 35.478969] Mem abort info:
> [ 35.479296] ESR = 0x96000004
> [ 35.479785] Exception class = DABT (current EL), IL = 32 bits
> [ 35.480528] SET = 0, FnV = 0
> [ 35.480980] EA = 0, S1PTW = 0
> [ 35.481345] Data abort info:
> [ 35.481680] ISV = 0, ISS = 0x00000004
> [ 35.482267] CM = 0, WnR = 0
> [ 35.482618] user pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____)
> [ 35.483486] [0000000000000070] pgd=0000000000000000
> [ 35.484041] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> [ 35.484788] Modules linked in:
> [ 35.485311] CPU: 113 PID: 3973 Comm: io_uring_regist Not tainted 5.1.0-rc3-00012-g40b114779944 #1
> [ 35.486712] Hardware name: linux,dummy-virt (DT)
> [ 35.487450] pstate: 20400005 (nzCv daif +PAN -UAO)
> [ 35.488228] pc : link_pwq+0x10/0x60
> [ 35.488794] lr : apply_wqattrs_commit+0xe0/0x118
> [ 35.489550] sp : ffff000017e2bbc0
Huh, this looks odd, it's crashing inside the wq setup.
--
Jens Axboe
next prev parent reply other threads:[~2019-04-03 13:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 14:34 [PATCH 1/2] io_uring: fix big-endian compat signal mask handling Arnd Bergmann
2019-03-25 14:47 ` [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere Arnd Bergmann
2019-03-25 17:37 ` Paul Burton
2019-03-26 8:40 ` Arnd Bergmann
2019-03-30 9:42 ` Heiko Carstens
2019-03-31 9:47 ` Michael Ellerman
2019-03-31 16:28 ` Arnd Bergmann
2019-04-03 1:19 ` Michael Ellerman
2019-04-01 8:19 ` Geert Uytterhoeven
2019-04-03 2:47 ` Michael Ellerman
2019-04-03 11:11 ` Will Deacon
2019-04-03 13:49 ` Jens Axboe [this message]
2019-04-03 15:19 ` Will Deacon
2019-04-03 15:39 ` Jens Axboe
2019-04-03 15:49 ` Will Deacon
2019-04-03 15:51 ` Jens Axboe
2019-04-04 6:08 ` Michael Ellerman
2019-03-25 16:05 ` [PATCH 1/2] io_uring: fix big-endian compat signal mask handling Jens Axboe
2019-03-25 16:11 ` Arnd Bergmann
2019-03-25 16:15 ` Jens Axboe
2019-03-25 16:19 ` James Bottomley
2019-03-25 16:23 ` Jens Axboe
2019-03-25 16:24 ` Arnd Bergmann
2019-03-26 0:13 ` James Bottomley
2019-03-26 8:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d673dfd-0051-3676-653e-6376430d73dd@kernel.dk \
--to=axboe@kernel.dk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=firoz.khan@linaro.org \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=jhogan@kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mattst88@gmail.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).