* [PATCH 0/7] ASoC: Mark expected switch fall-throughs
@ 2018-08-03 16:26 Gustavo A. R. Silva
2018-08-03 16:28 ` [PATCH 1/7] ASoC: davinci-i2s: mark expected switch fall-through Gustavo A. R. Silva
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-03 16:26 UTC (permalink / raw)
To: linux-kernel, Timur Tabi, Nicolin Chen, Xiubo Li, Fabio Estevam,
linuxppc-dev, Pierre-Louis Bossart, Peter Ujfalusi,
Jarkko Nikula, linux-omap, Krzysztof Kozlowski, Sangbeom Kim,
Sylwester Nawrocki
Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Gustavo A. R. Silva
Hi all,
In preparation to enabling -Wimplicit-fallthrough, this patchset aims
to add some annotations in order to mark switch cases where we are
expecting to fall through.
Thanks
Gustavo A. R. Silva (7):
ASoC: davinci-i2s: mark expected switch fall-through
ASoC: fsl_esai: Mark expected switch fall-through
ASoC: Intel: skl-pcm: Mark expected switch fall-through
ASoC: omap-dmic: Mark expected switch fall-throughs
ASoC: omap-mcpdm: MArk expected switch fall-throughs
ASoC: samsung: i2s: Mark expected switch fall-through
ASoC: core: mark expected switch fall-through
sound/soc/davinci/davinci-i2s.c | 1 +
sound/soc/fsl/fsl_esai.c | 1 +
sound/soc/intel/skylake/skl-pcm.c | 1 +
sound/soc/omap/omap-dmic.c | 2 ++
sound/soc/omap/omap-mcpdm.c | 4 ++++
sound/soc/samsung/i2s.c | 1 +
sound/soc/soc-core.c | 1 +
7 files changed, 11 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/7] ASoC: davinci-i2s: mark expected switch fall-through
2018-08-03 16:26 [PATCH 0/7] ASoC: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2018-08-03 16:28 ` Gustavo A. R. Silva
2018-08-03 16:29 ` [PATCH 2/7] ASoC: fsl_esai: Mark " Gustavo A. R. Silva
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-03 16:28 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1364478 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/davinci/davinci-i2s.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/davinci/davinci-i2s.c b/sound/soc/davinci/davinci-i2s.c
index 807040b..a3206e65 100644
--- a/sound/soc/davinci/davinci-i2s.c
+++ b/sound/soc/davinci/davinci-i2s.c
@@ -340,6 +340,7 @@ static int davinci_i2s_set_dai_fmt(struct snd_soc_dai *cpu_dai,
* rate is lowered.
*/
inv_fs = true;
+ /* fall through */
case SND_SOC_DAIFMT_DSP_A:
dev->mode = MOD_DSP_A;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/7] ASoC: fsl_esai: Mark expected switch fall-through
2018-08-03 16:26 [PATCH 0/7] ASoC: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-03 16:28 ` [PATCH 1/7] ASoC: davinci-i2s: mark expected switch fall-through Gustavo A. R. Silva
@ 2018-08-03 16:29 ` Gustavo A. R. Silva
2018-08-03 16:30 ` [PATCH 3/7] ASoC: Intel: skl-pcm: " Gustavo A. R. Silva
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-03 16:29 UTC (permalink / raw)
To: Timur Tabi, Nicolin Chen, Xiubo Li, Fabio Estevam, linuxppc-dev,
linux-kernel
Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1222121 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/fsl/fsl_esai.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index 8f43110..c1d1d06 100644
--- a/sound/soc/fsl/fsl_esai.c
+++ b/sound/soc/fsl/fsl_esai.c
@@ -249,6 +249,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
break;
case ESAI_HCKT_EXTAL:
ecr |= ESAI_ECR_ETI;
+ /* fall through */
case ESAI_HCKR_EXTAL:
ecr |= ESAI_ECR_ERI;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/7] ASoC: Intel: skl-pcm: Mark expected switch fall-through
2018-08-03 16:26 [PATCH 0/7] ASoC: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-03 16:28 ` [PATCH 1/7] ASoC: davinci-i2s: mark expected switch fall-through Gustavo A. R. Silva
2018-08-03 16:29 ` [PATCH 2/7] ASoC: fsl_esai: Mark " Gustavo A. R. Silva
@ 2018-08-03 16:30 ` Gustavo A. R. Silva
2018-08-03 16:31 ` [PATCH 4/7] ASoC: omap-dmic: Mark expected switch fall-throughs Gustavo A. R. Silva
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-03 16:30 UTC (permalink / raw)
To: Pierre-Louis Bossart, Jie Yang, linux-kernel
Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1357418 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/intel/skylake/skl-pcm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index 823e391..62d6f2f 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -494,6 +494,7 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
stream->lpib);
snd_hdac_ext_stream_set_lpib(stream, stream->lpib);
}
+ /* fall through */
case SNDRV_PCM_TRIGGER_START:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/7] ASoC: omap-dmic: Mark expected switch fall-throughs
2018-08-03 16:26 [PATCH 0/7] ASoC: Mark expected switch fall-throughs Gustavo A. R. Silva
` (2 preceding siblings ...)
2018-08-03 16:30 ` [PATCH 3/7] ASoC: Intel: skl-pcm: " Gustavo A. R. Silva
@ 2018-08-03 16:31 ` Gustavo A. R. Silva
2018-08-03 16:32 ` [PATCH 5/7] ASoC: omap-mcpdm: " Gustavo A. R. Silva
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-03 16:31 UTC (permalink / raw)
To: Peter Ujfalusi, Jarkko Nikula, linux-omap, linux-kernel
Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1468847 ("Missing break in switch")
Addresses-Coverity-ID: 1468849 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/omap/omap-dmic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
index 51dd7c6..fe96627 100644
--- a/sound/soc/omap/omap-dmic.c
+++ b/sound/soc/omap/omap-dmic.c
@@ -213,8 +213,10 @@ static int omap_dmic_dai_hw_params(struct snd_pcm_substream *substream,
switch (channels) {
case 6:
dmic->ch_enabled |= OMAP_DMIC_UP3_ENABLE;
+ /* fall through */
case 4:
dmic->ch_enabled |= OMAP_DMIC_UP2_ENABLE;
+ /* fall through */
case 2:
dmic->ch_enabled |= OMAP_DMIC_UP1_ENABLE;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 5/7] ASoC: omap-mcpdm: Mark expected switch fall-throughs
2018-08-03 16:26 [PATCH 0/7] ASoC: Mark expected switch fall-throughs Gustavo A. R. Silva
` (3 preceding siblings ...)
2018-08-03 16:31 ` [PATCH 4/7] ASoC: omap-dmic: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2018-08-03 16:32 ` Gustavo A. R. Silva
2018-08-03 16:33 ` [PATCH 6/7] ASoC: samsung: i2s: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-03 16:34 ` [PATCH 7/7] ASoC: core: mark " Gustavo A. R. Silva
6 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-03 16:32 UTC (permalink / raw)
To: Peter Ujfalusi, Jarkko Nikula, linux-omap, linux-kernel
Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1369526 ("Missing break in switch")
Addresses-Coverity-ID: 1369529 ("Missing break in switch")
Addresses-Coverity-ID: 1451415 ("Missing break in switch")
Addresses-Coverity-ID: 115103 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/omap/omap-mcpdm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc/omap/omap-mcpdm.c
index 0e97360..4c1be36 100644
--- a/sound/soc/omap/omap-mcpdm.c
+++ b/sound/soc/omap/omap-mcpdm.c
@@ -310,15 +310,19 @@ static int omap_mcpdm_dai_hw_params(struct snd_pcm_substream *substream,
/* up to 3 channels for capture */
return -EINVAL;
link_mask |= 1 << 4;
+ /* fall through */
case 4:
if (stream == SNDRV_PCM_STREAM_CAPTURE)
/* up to 3 channels for capture */
return -EINVAL;
link_mask |= 1 << 3;
+ /* fall through */
case 3:
link_mask |= 1 << 2;
+ /* fall through */
case 2:
link_mask |= 1 << 1;
+ /* fall through */
case 1:
link_mask |= 1 << 0;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 6/7] ASoC: samsung: i2s: Mark expected switch fall-through
2018-08-03 16:26 [PATCH 0/7] ASoC: Mark expected switch fall-throughs Gustavo A. R. Silva
` (4 preceding siblings ...)
2018-08-03 16:32 ` [PATCH 5/7] ASoC: omap-mcpdm: " Gustavo A. R. Silva
@ 2018-08-03 16:33 ` Gustavo A. R. Silva
2018-08-03 16:34 ` [PATCH 7/7] ASoC: core: mark " Gustavo A. R. Silva
6 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-03 16:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sangbeom Kim, Sylwester Nawrocki, linux-kernel
Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1381093 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/samsung/i2s.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index f914ed4..d6c62aa 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -710,6 +710,7 @@ static int i2s_hw_params(struct snd_pcm_substream *substream,
switch (params_channels(params)) {
case 6:
val |= MOD_DC2_EN;
+ /* fall through */
case 4:
val |= MOD_DC1_EN;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 7/7] ASoC: core: mark expected switch fall-through
2018-08-03 16:26 [PATCH 0/7] ASoC: Mark expected switch fall-throughs Gustavo A. R. Silva
` (5 preceding siblings ...)
2018-08-03 16:33 ` [PATCH 6/7] ASoC: samsung: i2s: Mark expected switch fall-through Gustavo A. R. Silva
@ 2018-08-03 16:34 ` Gustavo A. R. Silva
6 siblings, 0 replies; 8+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-03 16:34 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 146568 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/soc-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 82eb386..9cfe10d 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -528,6 +528,7 @@ int snd_soc_suspend(struct device *dev)
"ASoC: idle_bias_off CODEC on over suspend\n");
break;
}
+ /* fall through */
case SND_SOC_BIAS_OFF:
if (component->driver->suspend)
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-08-03 16:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-03 16:26 [PATCH 0/7] ASoC: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-03 16:28 ` [PATCH 1/7] ASoC: davinci-i2s: mark expected switch fall-through Gustavo A. R. Silva
2018-08-03 16:29 ` [PATCH 2/7] ASoC: fsl_esai: Mark " Gustavo A. R. Silva
2018-08-03 16:30 ` [PATCH 3/7] ASoC: Intel: skl-pcm: " Gustavo A. R. Silva
2018-08-03 16:31 ` [PATCH 4/7] ASoC: omap-dmic: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-03 16:32 ` [PATCH 5/7] ASoC: omap-mcpdm: " Gustavo A. R. Silva
2018-08-03 16:33 ` [PATCH 6/7] ASoC: samsung: i2s: Mark expected switch fall-through Gustavo A. R. Silva
2018-08-03 16:34 ` [PATCH 7/7] ASoC: core: mark " Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).