* [PATCH -next] RDMA/hns: Make hns_roce_cmq_send static
@ 2019-03-20 13:50 Yue Haibing
2019-03-20 15:28 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: Yue Haibing @ 2019-03-20 13:50 UTC (permalink / raw)
To: oulijun, xavier.huwei, dledford, jgg; +Cc: linux-kernel, linux-rdma, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1089:5:
warning: symbol 'hns_roce_cmq_send' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 1c54390..b13436e 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -1086,7 +1086,7 @@ static int __hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
return ret;
}
-int hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
+static int hns_roce_cmq_send(struct hns_roce_dev *hr_dev,
struct hns_roce_cmq_desc *desc, int num)
{
int retval;
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] RDMA/hns: Make hns_roce_cmq_send static
2019-03-20 13:50 [PATCH -next] RDMA/hns: Make hns_roce_cmq_send static Yue Haibing
@ 2019-03-20 15:28 ` Leon Romanovsky
2019-03-20 15:32 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2019-03-20 15:28 UTC (permalink / raw)
To: Yue Haibing
Cc: oulijun, xavier.huwei, dledford, jgg, linux-kernel, linux-rdma
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Wed, Mar 20, 2019 at 09:50:47PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1089:5:
> warning: symbol 'hns_roce_cmq_send' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks for your patch, but such fix was already submitted.
https://patchwork.kernel.org/patch/10859135/
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] RDMA/hns: Make hns_roce_cmq_send static
2019-03-20 15:28 ` Leon Romanovsky
@ 2019-03-20 15:32 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-03-20 15:32 UTC (permalink / raw)
To: Leon Romanovsky
Cc: oulijun, xavier.huwei, dledford, jgg, linux-kernel, linux-rdma
On 2019/3/20 23:28, Leon Romanovsky wrote:
> On Wed, Mar 20, 2019 at 09:50:47PM +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> Fix sparse warning:
>>
>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1089:5:
>> warning: symbol 'hns_roce_cmq_send' was not declared. Should it be static?
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Thanks for your patch, but such fix was already submitted.
> https://patchwork.kernel.org/patch/10859135/
Good to know this, Thanks!
>
> Thanks
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-20 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 13:50 [PATCH -next] RDMA/hns: Make hns_roce_cmq_send static Yue Haibing
2019-03-20 15:28 ` Leon Romanovsky
2019-03-20 15:32 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).