From: Sam Bobroff <sbobroff@linux.ibm.com>
To: airlied@redhat.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] drm/ast: Fix incorrect free on ioregs
Date: Mon, 5 Nov 2018 16:57:47 +1100 [thread overview]
Message-ID: <9e419efe28abb38b3935ee33d886630be43f0bf3.1541397462.git.sbobroff@linux.ibm.com> (raw)
In-Reply-To: <cover.1541397462.git.sbobroff@linux.ibm.com>
If the platform has no IO space, ioregs is placed next to the already
allocated regs. In this case, it should not be separately freed.
This prevents a kernel warning from __vunmap "Trying to vfree()
nonexistent vm area" when unloading the driver.
Fixes: 0dd68309b9c5 ("drm/ast: Try to use MMIO registers when PIO isn't supported")
Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
---
drivers/gpu/drm/ast/ast_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
index dac355812adc..373700c05a00 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -583,7 +583,8 @@ void ast_driver_unload(struct drm_device *dev)
drm_mode_config_cleanup(dev);
ast_mm_fini(ast);
- pci_iounmap(dev->pdev, ast->ioregs);
+ if (ast->ioregs != ast->regs + AST_IO_MM_OFFSET)
+ pci_iounmap(dev->pdev, ast->ioregs);
pci_iounmap(dev->pdev, ast->regs);
kfree(ast);
}
--
2.19.0.2.gcad72f5712
next prev parent reply other threads:[~2018-11-05 5:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 5:57 [PATCH 0/2] Two AST driver fixes Sam Bobroff
2018-11-05 5:57 ` Sam Bobroff [this message]
2018-11-05 5:57 ` [PATCH 2/2] drm/ast: Fix connector leak during driver unload Sam Bobroff
2018-11-28 23:40 ` Dave Airlie
2018-11-29 2:00 ` Sam Bobroff
2018-11-29 8:56 ` Daniel Vetter
2018-11-30 0:17 ` Sam Bobroff
2018-11-30 9:41 ` Daniel Vetter
2018-12-03 0:46 ` Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e419efe28abb38b3935ee33d886630be43f0bf3.1541397462.git.sbobroff@linux.ibm.com \
--to=sbobroff@linux.ibm.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).