From: Dave Airlie <airlied@gmail.com>
To: sbobroff@linux.ibm.com
Cc: Dave Airlie <airlied@redhat.com>, Dave Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload
Date: Thu, 29 Nov 2018 09:40:53 +1000 [thread overview]
Message-ID: <CAPM=9txRjd6E3DxdcM14mzWG1P-Cr70P61Eyce95bBhJtqfH7A@mail.gmail.com> (raw)
In-Reply-To: <3350c5dd5ea08c71e4769ea3801290e7f9238a6c.1541397462.git.sbobroff@linux.ibm.com>
On Mon, 5 Nov 2018 at 15:59, Sam Bobroff <sbobroff@linux.ibm.com> wrote:
>
> When unloading the ast driver, a warning message is printed by
> drm_mode_config_cleanup() because a reference is still held to one of
> the drm_connector structs.
>
> Correct this by calling drm_framebuffer_remove() in
> ast_fbdev_destroy().
>
> Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
> ---
> drivers/gpu/drm/ast/ast_fb.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index 0cd827e11fa2..655372ea81e9 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -263,6 +263,10 @@ static void ast_fbdev_destroy(struct drm_device *dev,
> {
> struct ast_framebuffer *afb = &afbdev->afb;
>
> + /* drm_framebuffer_remove() expects us to hold a ref, which it
> + * will drop, so take one: */
> + drm_framebuffer_get(&afb->base);
> + drm_framebuffer_remove(&afb->base);
This doesn't seem corret, no other driver does this pattern, and I
can't believe ast is special here.
The get just doesn't make sense.
Dave.
next prev parent reply other threads:[~2018-11-28 23:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 5:57 [PATCH 0/2] Two AST driver fixes Sam Bobroff
2018-11-05 5:57 ` [PATCH 1/2] drm/ast: Fix incorrect free on ioregs Sam Bobroff
2018-11-05 5:57 ` [PATCH 2/2] drm/ast: Fix connector leak during driver unload Sam Bobroff
2018-11-28 23:40 ` Dave Airlie [this message]
2018-11-29 2:00 ` Sam Bobroff
2018-11-29 8:56 ` Daniel Vetter
2018-11-30 0:17 ` Sam Bobroff
2018-11-30 9:41 ` Daniel Vetter
2018-12-03 0:46 ` Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9txRjd6E3DxdcM14mzWG1P-Cr70P61Eyce95bBhJtqfH7A@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sbobroff@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).