* [PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure
[not found] <CGME20200521143647epcas5p279d486b29125419c67ff96e0b5b1454e@epcas5p2.samsung.com>
@ 2020-05-21 14:22 ` Tamseel Shams
2020-06-01 8:09 ` Inki Dae
0 siblings, 1 reply; 2+ messages in thread
From: Tamseel Shams @ 2020-05-21 14:22 UTC (permalink / raw)
To: inki.dae, jy0922.shim, sw0312.kim, kyungmin.park, airlied, daniel
Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel,
shaik.ameer, krzk, alim.akhtar, Tamseel Shams
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Signed-off-by: Tamseel Shams <m.shams@samsung.com>
---
- Changes since v2:
* Addressed Inki Dae comments
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index fcee33a43aca..03be31427181 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -1498,7 +1498,6 @@ static int g2d_probe(struct platform_device *pdev)
g2d->irq = platform_get_irq(pdev, 0);
if (g2d->irq < 0) {
- dev_err(dev, "failed to get irq\n");
ret = g2d->irq;
goto err_put_clk;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure
2020-05-21 14:22 ` [PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure Tamseel Shams
@ 2020-06-01 8:09 ` Inki Dae
0 siblings, 0 replies; 2+ messages in thread
From: Inki Dae @ 2020-06-01 8:09 UTC (permalink / raw)
To: Tamseel Shams, jy0922.shim, sw0312.kim, kyungmin.park, airlied, daniel
Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel,
shaik.ameer, krzk, alim.akhtar
20. 5. 21. 오후 11:22에 Tamseel Shams 이(가) 쓴 글:
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
Picked it up.
Thanks,
Inki Dae
>
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> - Changes since v2:
> * Addressed Inki Dae comments
>
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index fcee33a43aca..03be31427181 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -1498,7 +1498,6 @@ static int g2d_probe(struct platform_device *pdev)
>
> g2d->irq = platform_get_irq(pdev, 0);
> if (g2d->irq < 0) {
> - dev_err(dev, "failed to get irq\n");
> ret = g2d->irq;
> goto err_put_clk;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-01 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200521143647epcas5p279d486b29125419c67ff96e0b5b1454e@epcas5p2.samsung.com>
2020-05-21 14:22 ` [PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure Tamseel Shams
2020-06-01 8:09 ` Inki Dae
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).