* [PATCH -next] phy: ti: dm816x: remove set but not used variable 'phy_data'
@ 2019-10-23 7:45 YueHaibing
2019-10-23 8:08 ` Roger Quadros
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-10-23 7:45 UTC (permalink / raw)
To: kishon, yuehaibing, rogerq; +Cc: linux-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/phy/ti/phy-dm816x-usb.c:192:29: warning:
variable phy_data set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/phy/ti/phy-dm816x-usb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/phy/ti/phy-dm816x-usb.c b/drivers/phy/ti/phy-dm816x-usb.c
index cbcce7c..26f1947 100644
--- a/drivers/phy/ti/phy-dm816x-usb.c
+++ b/drivers/phy/ti/phy-dm816x-usb.c
@@ -189,7 +189,6 @@ static int dm816x_usb_phy_probe(struct platform_device *pdev)
struct phy_provider *phy_provider;
struct usb_otg *otg;
const struct of_device_id *of_id;
- const struct usb_phy_data *phy_data;
int error;
of_id = of_match_device(of_match_ptr(dm816x_usb_phy_id_table),
@@ -220,8 +219,6 @@ static int dm816x_usb_phy_probe(struct platform_device *pdev)
if (phy->usbphy_ctrl == 0x2c)
phy->instance = 1;
- phy_data = of_id->data;
-
otg = devm_kzalloc(&pdev->dev, sizeof(*otg), GFP_KERNEL);
if (!otg)
return -ENOMEM;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] phy: ti: dm816x: remove set but not used variable 'phy_data'
2019-10-23 7:45 [PATCH -next] phy: ti: dm816x: remove set but not used variable 'phy_data' YueHaibing
@ 2019-10-23 8:08 ` Roger Quadros
0 siblings, 0 replies; 2+ messages in thread
From: Roger Quadros @ 2019-10-23 8:08 UTC (permalink / raw)
To: YueHaibing, kishon; +Cc: linux-kernel
On 23/10/2019 10:45, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/phy/ti/phy-dm816x-usb.c:192:29: warning:
> variable phy_data set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
> ---
> drivers/phy/ti/phy-dm816x-usb.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/phy/ti/phy-dm816x-usb.c b/drivers/phy/ti/phy-dm816x-usb.c
> index cbcce7c..26f1947 100644
> --- a/drivers/phy/ti/phy-dm816x-usb.c
> +++ b/drivers/phy/ti/phy-dm816x-usb.c
> @@ -189,7 +189,6 @@ static int dm816x_usb_phy_probe(struct platform_device *pdev)
> struct phy_provider *phy_provider;
> struct usb_otg *otg;
> const struct of_device_id *of_id;
> - const struct usb_phy_data *phy_data;
> int error;
>
> of_id = of_match_device(of_match_ptr(dm816x_usb_phy_id_table),
> @@ -220,8 +219,6 @@ static int dm816x_usb_phy_probe(struct platform_device *pdev)
> if (phy->usbphy_ctrl == 0x2c)
> phy->instance = 1;
>
> - phy_data = of_id->data;
> -
> otg = devm_kzalloc(&pdev->dev, sizeof(*otg), GFP_KERNEL);
> if (!otg)
> return -ENOMEM;
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-23 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 7:45 [PATCH -next] phy: ti: dm816x: remove set but not used variable 'phy_data' YueHaibing
2019-10-23 8:08 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).