* [PATCH] drm/msm/dp: Add "qcom,sc7280-dp" to support display port.
@ 2021-12-03 22:02 Kuogee Hsieh
2021-12-05 0:04 ` Dmitry Baryshkov
2021-12-05 4:05 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Kuogee Hsieh @ 2021-12-03 22:02 UTC (permalink / raw)
To: robdclark, sean, swboyd, vkoul, daniel, airlied, agross,
dmitry.baryshkov, bjorn.andersson
Cc: quic_abhinavk, aravindh, quic_khsieh, quic_sbillaka, freedreno,
dri-devel, linux-arm-msm, linux-kernel
Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index d44f18b..91582d3 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -146,6 +146,7 @@ static const struct msm_dp_config sc7280_dp_cfg = {
static const struct of_device_id dp_dt_match[] = {
{ .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
{ .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
+ { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
{}
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/dp: Add "qcom,sc7280-dp" to support display port.
2021-12-03 22:02 [PATCH] drm/msm/dp: Add "qcom,sc7280-dp" to support display port Kuogee Hsieh
@ 2021-12-05 0:04 ` Dmitry Baryshkov
2021-12-05 4:05 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2021-12-05 0:04 UTC (permalink / raw)
To: Kuogee Hsieh, robdclark, sean, swboyd, vkoul, daniel, airlied,
agross, bjorn.andersson
Cc: quic_abhinavk, aravindh, quic_sbillaka, freedreno, dri-devel,
linux-arm-msm, linux-kernel
On 04/12/2021 01:02, Kuogee Hsieh wrote:
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index d44f18b..91582d3 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -146,6 +146,7 @@ static const struct msm_dp_config sc7280_dp_cfg = {
> static const struct of_device_id dp_dt_match[] = {
> { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
> + { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
> {}
> };
>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/dp: Add "qcom,sc7280-dp" to support display port.
2021-12-03 22:02 [PATCH] drm/msm/dp: Add "qcom,sc7280-dp" to support display port Kuogee Hsieh
2021-12-05 0:04 ` Dmitry Baryshkov
@ 2021-12-05 4:05 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-12-05 4:05 UTC (permalink / raw)
To: Kuogee Hsieh, agross, airlied, bjorn.andersson, daniel,
dmitry.baryshkov, robdclark, sean, vkoul
Cc: quic_abhinavk, aravindh, quic_sbillaka, freedreno, dri-devel,
linux-arm-msm, linux-kernel
Quoting Kuogee Hsieh (2021-12-03 14:02:39)
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 1 +
> 1 file changed, 1 insertion(+)
One nit
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index d44f18b..91582d3 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -146,6 +146,7 @@ static const struct msm_dp_config sc7280_dp_cfg = {
> static const struct of_device_id dp_dt_match[] = {
> { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
> + { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
The letter d comes before e so it would be better to sort this
alphanumerically and avoid conflicts later.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-05 4:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-03 22:02 [PATCH] drm/msm/dp: Add "qcom,sc7280-dp" to support display port Kuogee Hsieh
2021-12-05 0:04 ` Dmitry Baryshkov
2021-12-05 4:05 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).