From: Vlastimil Babka <vbabka@suse.cz>
To: Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@kernel.org>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint
Date: Wed, 4 Jan 2017 08:28:43 +0100 [thread overview]
Message-ID: <9f77c4d2-dddf-8fc6-0982-edf02a58b15f@suse.cz> (raw)
In-Reply-To: <20170104050722.GA17166@bbox>
On 01/04/2017 06:07 AM, Minchan Kim wrote:
> With this,
> ./scripts/bloat-o-meter vmlinux.old vmlinux.new.new
> add/remove: 1/1 grow/shrink: 0/9 up/down: 1394/-1636 (-242)
> function old new delta
> isolate_lru_pages - 1394 +1394
> print_fmt_mm_vmscan_lru_shrink_inactive 359 355 -4
> vermagic 64 58 -6
> perf_trace_mm_vmscan_lru_shrink_active 264 256 -8
> trace_raw_output_mm_vmscan_lru_shrink_active 203 193 -10
> trace_event_raw_event_mm_vmscan_lru_shrink_active 241 225 -16
> print_fmt_mm_vmscan_lru_shrink_active 458 426 -32
> trace_event_define_fields_mm_vmscan_lru_shrink_active 384 336 -48
> shrink_inactive_list 1430 1271 -159
> shrink_active_list 1265 1082 -183
> isolate_lru_pages.isra 1170 - -1170
> Total: Before=26268743, After=26268501, chg -0.00%
>
> We can save 242 bytes.
>
> If we consider binary size, 424 bytes save.
>
> #> ls -l vmlinux.old vmlinux.new.new
> 194092840 vmlinux.old
> 194092416 vmlinux.new.new
Which is roughly 0.0002%. Not that I'm against fighting bloat, but let's
not forget that it's not the only factor. For example the following part
from above:
> isolate_lru_pages - 1394 +1394
> isolate_lru_pages.isra 1170 - -1170
shows that your change has prevented a -fipa-src gcc optimisation, which
is "interprocedural scalar replacement of aggregates, removal of unused
parameters and replacement of parameters passed by reference by
parameters passed by value." Well, I'm no gcc expert :) but it might be
that the change is not a simple win-win.
next prev parent reply other threads:[~2017-01-04 7:28 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 15:30 [PATCH 0/7] vm, vmscan: enahance vmscan tracepoints Michal Hocko
2016-12-28 15:30 ` [PATCH 1/7] mm, vmscan: remove unused mm_vmscan_memcg_isolate Michal Hocko
2016-12-29 7:33 ` Hillf Danton
2016-12-28 15:30 ` [PATCH 2/7] mm, vmscan: add active list aging tracepoint Michal Hocko
2016-12-29 5:33 ` Minchan Kim
2016-12-29 7:52 ` Michal Hocko
2016-12-30 1:48 ` Minchan Kim
2016-12-30 9:26 ` Michal Hocko
2016-12-30 9:38 ` Hillf Danton
2016-12-30 16:04 ` Minchan Kim
2016-12-30 16:37 ` Michal Hocko
2016-12-30 17:30 ` Michal Hocko
2017-01-03 5:03 ` Minchan Kim
2017-01-03 8:21 ` Michal Hocko
2017-01-04 5:07 ` Minchan Kim
2017-01-04 7:28 ` Vlastimil Babka [this message]
2017-01-04 7:50 ` Michal Hocko
2016-12-29 7:44 ` Hillf Danton
2016-12-28 15:30 ` [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate Michal Hocko
2016-12-29 5:53 ` Minchan Kim
2016-12-29 7:49 ` Hillf Danton
2017-01-03 17:21 ` Vlastimil Babka
2017-01-03 20:43 ` Michal Hocko
2016-12-28 15:30 ` [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint Michal Hocko
2016-12-28 15:50 ` Nikolay Borisov
2016-12-28 16:00 ` Michal Hocko
2016-12-28 16:40 ` Nikolay Borisov
2016-12-28 16:49 ` Michal Hocko
2016-12-29 6:02 ` Minchan Kim
2016-12-29 7:56 ` Michal Hocko
2016-12-30 1:56 ` Minchan Kim
2016-12-30 9:33 ` Michal Hocko
2016-12-29 7:53 ` Hillf Danton
2017-01-03 17:08 ` Vlastimil Babka
2017-01-03 20:47 ` Michal Hocko
2017-01-03 20:52 ` Michal Hocko
2017-01-03 21:24 ` Michal Hocko
2017-01-03 21:40 ` Vlastimil Babka
2017-01-03 21:48 ` Michal Hocko
2016-12-28 15:30 ` [PATCH 5/7] mm, vmscan: extract shrink_page_list reclaim counters into a struct Michal Hocko
2016-12-29 8:00 ` Hillf Danton
2016-12-28 15:30 ` [PATCH 6/7] mm, vmscan: enhance mm_vmscan_lru_shrink_inactive tracepoint Michal Hocko
2016-12-29 8:05 ` Hillf Danton
2016-12-28 15:30 ` [PATCH 7/7] mm, vmscan: add mm_vmscan_inactive_list_is_low tracepoint Michal Hocko
2016-12-29 8:19 ` Hillf Danton
2016-12-30 9:11 ` [PATCH 0/7] vm, vmscan: enahance vmscan tracepoints Mel Gorman
2016-12-30 9:36 ` Michal Hocko
2016-12-30 10:20 ` Mel Gorman
2017-01-04 10:19 [PATCH 0/7 v2] " Michal Hocko
2017-01-04 10:19 ` [PATCH 2/7] mm, vmscan: add active list aging tracepoint Michal Hocko
2017-01-04 12:52 ` Vlastimil Babka
2017-01-04 13:16 ` Michal Hocko
2017-01-04 13:34 ` Vlastimil Babka
2017-01-04 13:52 ` Michal Hocko
2017-01-05 5:41 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f77c4d2-dddf-8fc6-0982-edf02a58b15f@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).