linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [pdx86-platform-drivers-x86:review-hans 66/68] drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume'
@ 2022-07-04 10:51 kernel test robot
  2022-07-08 14:44 ` Hans de Goede
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2022-07-04 10:51 UTC (permalink / raw)
  To: Gayatri Kammela; +Cc: kbuild-all, Andy Shevchenko, Hans de Goede, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
head:   530ef2a6e81c74c19f918713e519e85652e53a83
commit: 1039bb2698ab299a1fc30a4fc2df237867c089e0 [66/68] platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220704/202207041814.S03OvoFK-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=1039bb2698ab299a1fc30a4fc2df237867c089e0
        git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
        git fetch --no-tags pdx86-platform-drivers-x86 review-hans
        git checkout 1039bb2698ab299a1fc30a4fc2df237867c089e0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/intel/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume' [-Wmissing-prototypes]
     475 | void intel_vsec_pci_resume(struct pci_dev *pdev)
         |      ^~~~~~~~~~~~~~~~~~~~~


vim +/intel_vsec_pci_resume +475 drivers/platform/x86/intel/vsec.c

   474	
 > 475	void intel_vsec_pci_resume(struct pci_dev *pdev)
   476	{
   477		dev_info(&pdev->dev, "Done resuming PCI device\n");
   478	}
   479	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pdx86-platform-drivers-x86:review-hans 66/68] drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume'
  2022-07-04 10:51 [pdx86-platform-drivers-x86:review-hans 66/68] drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume' kernel test robot
@ 2022-07-08 14:44 ` Hans de Goede
  2022-07-09  1:28   ` Kammela, Gayatri
  0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2022-07-08 14:44 UTC (permalink / raw)
  To: kernel test robot, Gayatri Kammela
  Cc: kbuild-all, Andy Shevchenko, linux-kernel

Hi,

On 7/4/22 12:51, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
> head:   530ef2a6e81c74c19f918713e519e85652e53a83
> commit: 1039bb2698ab299a1fc30a4fc2df237867c089e0 [66/68] platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT
> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220704/202207041814.S03OvoFK-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=1039bb2698ab299a1fc30a4fc2df237867c089e0
>         git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>         git fetch --no-tags pdx86-platform-drivers-x86 review-hans
>         git checkout 1039bb2698ab299a1fc30a4fc2df237867c089e0
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/intel/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>>> drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume' [-Wmissing-prototypes]
>      475 | void intel_vsec_pci_resume(struct pci_dev *pdev)
>          |      ^~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/intel_vsec_pci_resume +475 drivers/platform/x86/intel/vsec.c
> 
>    474	
>  > 475	void intel_vsec_pci_resume(struct pci_dev *pdev)
>    476	{
>    477		dev_info(&pdev->dev, "Done resuming PCI device\n");
>    478	}
>    479	
> 


I've squashed a patch marking intel_vsec_pci_resume() as static into my
review-hans branch.

Regards,

Hans


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pdx86-platform-drivers-x86:review-hans 66/68] drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume'
  2022-07-08 14:44 ` Hans de Goede
@ 2022-07-09  1:28   ` Kammela, Gayatri
  0 siblings, 0 replies; 3+ messages in thread
From: Kammela, Gayatri @ 2022-07-09  1:28 UTC (permalink / raw)
  To: Hans de Goede, kernel test robot
  Cc: kbuild-all, Andy Shevchenko, linux-kernel

On 7/8/2022 7:44 AM, Hans de Goede wrote:

> Hi,
>
> On 7/4/22 12:51, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
>> head:   530ef2a6e81c74c19f918713e519e85652e53a83
>> commit: 1039bb2698ab299a1fc30a4fc2df237867c089e0 [66/68] platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT
>> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220704/202207041814.S03OvoFK-lkp@intel.com/config)
>> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
>> reproduce (this is a W=1 build):
>>          # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=1039bb2698ab299a1fc30a4fc2df237867c089e0
>>          git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>>          git fetch --no-tags pdx86-platform-drivers-x86 review-hans
>>          git checkout 1039bb2698ab299a1fc30a4fc2df237867c089e0
>>          # save the config file
>>          mkdir build_dir && cp config build_dir/.config
>>          make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/intel/
>>
>> If you fix the issue, kindly add following tag where applicable
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume' [-Wmissing-prototypes]
>>       475 | void intel_vsec_pci_resume(struct pci_dev *pdev)
>>           |      ^~~~~~~~~~~~~~~~~~~~~
>>
>>
>> vim +/intel_vsec_pci_resume +475 drivers/platform/x86/intel/vsec.c
>>
>>     474	
>>   > 475	void intel_vsec_pci_resume(struct pci_dev *pdev)
>>     476	{
>>     477		dev_info(&pdev->dev, "Done resuming PCI device\n");
>>     478	}
>>     479	
>>
>
> I've squashed a patch marking intel_vsec_pci_resume() as static into my
> review-hans branch.
Thank you Hans!
>
> Regards,
>
> Hans
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-09  1:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 10:51 [pdx86-platform-drivers-x86:review-hans 66/68] drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume' kernel test robot
2022-07-08 14:44 ` Hans de Goede
2022-07-09  1:28   ` Kammela, Gayatri

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).