From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
David Airlie <airlied@linux.ie>,
Sebastian Reichel <sre@kernel.org>,
"Andrew F. Davis" <afd@ti.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH] drm: omapdrm: displays: fix port_num for opa362 output
Date: Wed, 22 Aug 2018 09:46:30 +0200 [thread overview]
Message-ID: <A1123AD2-C238-4F19-8AF7-3FB8F60BF62D@goldelico.com> (raw)
In-Reply-To: <6854891.0j5LuaEH9O@avalon>
Hi Laurent,
> Am 19.08.2018 um 16:07 schrieb Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
>
> Hi Nikolaus,
>
> Thank you for the patch.
>
> On Friday, 27 July 2018 17:24:32 EEST H. Nikolaus Schaller wrote:
>> The opa362 amplifier has two ports, an input (usually connected
>> to the OMAP3 VENC) and an output port connected to the external
>> connector.
>>
>> These are usually defined as input port@0 and outpt port@1 in
>> the DT and really distinguished by the reg = <port_num> property
>> of these nodes.
>>
>> But we are missing to define the output port as number 1 so
>> it does not match the DT entry.
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> I think this patch is superseded by "[PATCH v3 36/61] drm/omap: dss: Replace
> omap_dss_device port number with bitmask"
looks good and from cursory review it seems to resolve the opa362
bug as a side-effect. Maybe this can be noted in the commit description.
What I am not sure how this magically defines the output as
reg=<1> or if we have to swap reg number definitions in the DT.
But encoder-tfp410.c and encoder-tpd12s015.c seem to do it the
same way, so it is very likely that it works as defined.
> which should get merged in v4.20.
Well, I had hoped our bug fix makes it into v4.19 and can be
potentially backported to stable.
Do you plan to backport you patch? It seems to be quite independent
and should apply to older releases.
BR,
Nikolaus
prev parent reply other threads:[~2018-08-22 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 14:24 [PATCH] drm: omapdrm: displays: fix port_num for opa362 output H. Nikolaus Schaller
2018-08-19 14:07 ` Laurent Pinchart
2018-08-22 7:46 ` H. Nikolaus Schaller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A1123AD2-C238-4F19-8AF7-3FB8F60BF62D@goldelico.com \
--to=hns@goldelico.com \
--cc=afd@ti.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).