archive mirror
 help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <>
To: Tomi Valkeinen <>,
	David Airlie <>,
	Sebastian Reichel <>,
	Laurent Pinchart <>,
	"Andrew F. Davis" <>,
	"H. Nikolaus Schaller" <>
Subject: [PATCH] drm: omapdrm: displays: fix port_num for opa362 output
Date: Fri, 27 Jul 2018 16:24:32 +0200	[thread overview]
Message-ID: <> (raw)

The opa362 amplifier has two ports, an input (usually connected
to the OMAP3 VENC) and an output port connected to the external

These are usually defined as input port@0 and outpt port@1 in
the DT and really distinguished by the reg = <port_num> property
of these nodes.

But we are missing to define the output port as number 1 so
it does not match the DT entry.

Signed-off-by: H. Nikolaus Schaller <>
 drivers/gpu/drm/omapdrm/displays/encoder-opa362.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
index afee1b8b457a..296d46f060b2 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
@@ -208,6 +208,7 @@ static int opa362_probe(struct platform_device *pdev)
 	dssdev->type = OMAP_DISPLAY_TYPE_VENC;
 	dssdev->output_type = OMAP_DISPLAY_TYPE_VENC;
 	dssdev->owner = THIS_MODULE;
+	dssdev->port_num = 1;	/* second port */
 	r = omapdss_register_output(dssdev);
 	if (r) {

             reply	other threads:[~2018-07-27 14:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 14:24 H. Nikolaus Schaller [this message]
2018-08-19 14:07 ` [PATCH] drm: omapdrm: displays: fix port_num for opa362 output Laurent Pinchart
2018-08-22  7:46   ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).