* [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0
@ 2013-01-24 11:35 Vishwanathrao Badarkhe, Manish
2013-01-25 10:50 ` Sekhar Nori
0 siblings, 1 reply; 3+ messages in thread
From: Vishwanathrao Badarkhe, Manish @ 2013-01-24 11:35 UTC (permalink / raw)
To: devicetree-discuss, linux-doc, linux-kernel, linux-arm-kernel,
davinci-linux-open-source
Cc: anilkumar, tony, hs, broonie, lrg, sameo, khilman, linux, rob,
rob.herring, grant.likely, manishv.b
Add I2C0 device tree node information to da850-evm.
Also, add I2C0 pin muxing information in da850-evm.
Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
---
Depends on patch
http://comments.gmane.org/gmane.linux.davinci/25993
arch/arm/boot/dts/da850-evm.dts | 15 +++++++++++++++
arch/arm/boot/dts/da850.dtsi | 10 ++++++++++
2 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 8cac9d2..3d8290a 100755
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -27,5 +27,20 @@
serial2: serial@1d0d000 {
status = "okay";
};
+ i2c0@1c22000 {
+ status = "okay";
+ };
+ };
+};
+&pmx_core {
+ pinctrl-names = "default";
+ pinctrl-0 = <
+ &i2c0_pins
+ >;
+
+ i2c0_pins: pinmux_i2c0_pins{
+ pinctrl-single,bits = <
+ 0x10 0x00002200 0x0000ff00 /* I2C0_SDA,I2C0_SCL */
+ >;
};
};
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 1e6d090..f5ee811 100755
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -66,5 +66,15 @@
interrupt-parent = <&intc>;
status = "disabled";
};
+ i2c0@1c22000 {
+ compatible = "ti,davinci-i2c";
+ reg = <0x22000 0x1000>;
+ clock-frequency = <100000>;
+ interrupts = <15>;
+ interrupt-parent = <&intc>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
};
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0
2013-01-24 11:35 [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0 Vishwanathrao Badarkhe, Manish
@ 2013-01-25 10:50 ` Sekhar Nori
2013-01-28 5:17 ` Vishwanathrao Badarkhe, Manish
0 siblings, 1 reply; 3+ messages in thread
From: Sekhar Nori @ 2013-01-25 10:50 UTC (permalink / raw)
To: Vishwanathrao Badarkhe, Manish
Cc: devicetree-discuss, linux-doc, linux-kernel, linux-arm-kernel,
davinci-linux-open-source, Kevin Hilman, linux, sameo, tony,
broonie, rob.herring, grant.likely, rob, anilkumar, hs
On 1/24/2013 5:05 PM, Vishwanathrao Badarkhe, Manish wrote:
> Add I2C0 device tree node information to da850-evm.
> Also, add I2C0 pin muxing information in da850-evm.
>
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> ---
> Depends on patch
> http://comments.gmane.org/gmane.linux.davinci/25993
>
> arch/arm/boot/dts/da850-evm.dts | 15 +++++++++++++++
> arch/arm/boot/dts/da850.dtsi | 10 ++++++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 8cac9d2..3d8290a 100755
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -27,5 +27,20 @@
> serial2: serial@1d0d000 {
> status = "okay";
> };
> + i2c0@1c22000 {
This should be
i2c0: i2c@1c22000
to follow the convention elsewhere in file.
> + status = "okay";
> + };
> + };
> +};
> +&pmx_core {
> + pinctrl-names = "default";
> + pinctrl-0 = <
> + &i2c0_pins
> + >;
> +
> + i2c0_pins: pinmux_i2c0_pins{
> + pinctrl-single,bits = <
> + 0x10 0x00002200 0x0000ff00 /* I2C0_SDA,I2C0_SCL */
> + >;
This should go into the dtsi file. See the discussion on NAND DT support
submitted by Anil Kumar.
Thanks,
Sekhar
PS: You are using an old address for Kevin Hilman. The MAINTAINERS file
has been updated for a long time now. Liam's address is also wrong but I
don't have his updated e-mail.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0
2013-01-25 10:50 ` Sekhar Nori
@ 2013-01-28 5:17 ` Vishwanathrao Badarkhe, Manish
0 siblings, 0 replies; 3+ messages in thread
From: Vishwanathrao Badarkhe, Manish @ 2013-01-28 5:17 UTC (permalink / raw)
To: Nori, Sekhar
Cc: devicetree-discuss, linux-doc, linux-kernel, linux-arm-kernel,
davinci-linux-open-source, Kevin Hilman, linux, sameo, tony,
broonie, rob.herring, grant.likely, rob, AnilKumar, Chimata, hs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2542 bytes --]
On Fri, Jan 25, 2013 at 16:20:13, Nori, Sekhar wrote:
> On 1/24/2013 5:05 PM, Vishwanathrao Badarkhe, Manish wrote:
> > Add I2C0 device tree node information to da850-evm.
> > Also, add I2C0 pin muxing information in da850-evm.
> >
> > Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> > ---
> > Depends on patch
> > http://comments.gmane.org/gmane.linux.davinci/25993
> >
> > arch/arm/boot/dts/da850-evm.dts | 15 +++++++++++++++
> > arch/arm/boot/dts/da850.dtsi | 10 ++++++++++
> > 2 files changed, 25 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/da850-evm.dts
> > b/arch/arm/boot/dts/da850-evm.dts index 8cac9d2..3d8290a 100755
> > --- a/arch/arm/boot/dts/da850-evm.dts
> > +++ b/arch/arm/boot/dts/da850-evm.dts
> > @@ -27,5 +27,20 @@
> > serial2: serial@1d0d000 {
> > status = "okay";
> > };
> > + i2c0@1c22000 {
>
> This should be
> i2c0: i2c@1c22000
>
> to follow the convention elsewhere in file.
Ok, I will change this in next version.
>
> > + status = "okay";
> > + };
> > + };
> > +};
> > +&pmx_core {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <
> > + &i2c0_pins
> > + >;
> > +
> > + i2c0_pins: pinmux_i2c0_pins{
> > + pinctrl-single,bits = <
> > + 0x10 0x00002200 0x0000ff00 /* I2C0_SDA,I2C0_SCL */
> > + >;
>
> This should go into the dtsi file. See the discussion on NAND DT support submitted by Anil Kumar.
I have seen Anil Kumar's discussion for pin-muxing which includes Linus patch of grab pin
control handles from device core at following location:
http://lkml.indiana.edu/hypermail/linux/kernel/1301.2/00094.html
I have done changes accordingly for I2C0 pin muxing and seen kernel crashes giving message
like "i2c_davinci i2c_davinci.1: could not find pctldev for node /soc/
pinmux@1c14120/pinmux_i2c0_pins, deferring probe". This is happened because I2C0 driver
gets probed before pin mux driver.
To resolve this issue, I made changes in code to ensure pin control driver gets probed before
I2C0 driver by registering pin control driver during arch_init call.
Hence, in order to move I2C0 pin muxing in dtsi file above fix is required.
>
> Thanks,
> Sekhar
>
> PS: You are using an old address for Kevin Hilman. The MAINTAINERS file has been updated for a long time now. Liam's address is also wrong but I don't have his updated e-mail.
>
Regards,
Manish
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-28 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-24 11:35 [PATCH 2/6] ARM: davinci: da850: add DT node for I2C0 Vishwanathrao Badarkhe, Manish
2013-01-25 10:50 ` Sekhar Nori
2013-01-28 5:17 ` Vishwanathrao Badarkhe, Manish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).