* [PATCH 05/33] leds-lp55xx: add device reset function in lp5521/5523
@ 2012-12-12 14:00 Kim, Milo
0 siblings, 0 replies; only message in thread
From: Kim, Milo @ 2012-12-12 14:00 UTC (permalink / raw)
To: Bryan Wu; +Cc: linux-leds, linux-kernel
Use explicit each driver function rather than raw command.
These function will be merged into the lp55xx common driver.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/leds/leds-lp5521.c | 10 +++++++++-
drivers/leds/leds-lp5523.c | 10 +++++++++-
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index f729f7a..37075fd 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -687,6 +687,13 @@ static void lp5521_unregister_sysfs(struct i2c_client *client)
&lp5521_led_attribute_group);
}
+static void lp5521_reset_device(struct lp5521_chip *chip)
+{
+ struct i2c_client *client = chip->client;
+
+ lp5521_write(client, LP5521_REG_RESET, 0xff);
+}
+
static int lp5521_init_device(struct lp5521_chip *chip)
{
struct lp5521_platform_data *pdata = chip->pdata;
@@ -707,7 +714,8 @@ static int lp5521_init_device(struct lp5521_chip *chip)
usleep_range(1000, 2000); /* 500us abs min. */
}
- lp5521_write(client, LP5521_REG_RESET, 0xff);
+ lp5521_reset_device(chip);
+
usleep_range(10000, 20000); /*
* Exact value is not available. 10 - 20ms
* appears to be enough for reset.
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 6a1c4f2..ec21642 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -946,6 +946,13 @@ static void lp5523_unregister_leds(struct lp5523_chip *chip)
}
}
+static void lp5523_reset_device(struct lp5523_chip *chip)
+{
+ struct i2c_client *client = chip->client;
+
+ lp5523_write(client, LP5523_REG_RESET, 0xff);
+}
+
static int lp5523_init_device(struct lp5523_chip *chip)
{
struct lp5523_platform_data *pdata = chip->pdata;
@@ -965,7 +972,8 @@ static int lp5523_init_device(struct lp5523_chip *chip)
usleep_range(1000, 2000); /* 500us abs min. */
}
- lp5523_write(client, LP5523_REG_RESET, 0xff);
+ lp5523_reset_device(chip);
+
usleep_range(10000, 20000); /*
* Exact value is not available. 10 - 20ms
* appears to be enough for reset.
--
1.7.9.5
Best Regards,
Milo
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-12-12 14:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-12 14:00 [PATCH 05/33] leds-lp55xx: add device reset function in lp5521/5523 Kim, Milo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).