linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sched/cputime: silence a -Wunused-function warning
@ 2020-03-06 15:41 Qian Cai
  2020-03-06 17:13 ` Nick Desaulniers
  0 siblings, 1 reply; 12+ messages in thread
From: Qian Cai @ 2020-03-06 15:41 UTC (permalink / raw)
  To: peterz, mingo
  Cc: juri.lelli, vincent.guittot, dietmar.eggemann, rostedt, bsegall,
	mgorman, linux-kernel, clang-built-linux, Qian Cai

account_other_time() is only used when CONFIG_IRQ_TIME_ACCOUNTING=y (in
irqtime_account_process_tick()) or CONFIG_VIRT_CPU_ACCOUNTING_GEN=y (in
get_vtime_delta()). When both are off, it will generate a compilation
warning from Clang,

kernel/sched/cputime.c:255:19: warning: unused function
'account_other_time' [-Wunused-function]
static inline u64 account_other_time(u64 max)

Rather than wrapping around this function with a macro expression,

 if defined(CONFIG_IRQ_TIME_ACCOUNTING) || \
    defined(CONFIG_VIRT_CPU_ACCOUNTING_GEN)

just use __maybe_unused for this small function which seems like a good
trade-off.

Signed-off-by: Qian Cai <cai@lca.pw>
---
 kernel/sched/cputime.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index cff3e656566d..85da4d6dee24 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -252,7 +252,7 @@ static __always_inline u64 steal_account_process_time(u64 maxtime)
 /*
  * Account how much elapsed time was spent in steal, irq, or softirq time.
  */
-static inline u64 account_other_time(u64 max)
+static inline __maybe_unused u64 account_other_time(u64 max)
 {
 	u64 accounted;
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-11-29 23:57 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 15:41 [PATCH] sched/cputime: silence a -Wunused-function warning Qian Cai
2020-03-06 17:13 ` Nick Desaulniers
2020-03-06 17:25   ` Joe Perches
2020-03-06 18:38     ` Joe Perches
2020-03-06 19:02       ` Nick Desaulniers
2020-03-06 19:10         ` Joe Perches
2020-03-07  0:07         ` linux-kernel: Unused static inline functions Joe Perches
2020-04-23 18:57           ` Nick Desaulniers
2020-04-23 21:22             ` Joe Perches
2020-04-24 16:07               ` Julia Lawall
2020-11-29 23:56           ` Joe Perches
2020-05-09 13:12   ` [PATCH] sched/cputime: silence a -Wunused-function warning Qian Cai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).