* dmaengine: Fix i.MX sdma firmware loading
@ 2011-01-12 10:18 Sascha Hauer
2011-01-12 10:18 ` [PATCH] dmaengine i.MX SDMA: Fix " Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2011-01-12 10:18 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-arm-kernel, Dan Williams
The firmware loading in the i.MX sdma engine is currently broken. The
following patch fixes this. Dan, please forward this patch for current
-rc.
Sascha Hauer (1):
dmaengine i.MX SDMA: Fix firmware loading
drivers/dma/imx-sdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] dmaengine i.MX SDMA: Fix firmware loading
2011-01-12 10:18 dmaengine: Fix i.MX sdma firmware loading Sascha Hauer
@ 2011-01-12 10:18 ` Sascha Hauer
2011-01-15 0:23 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2011-01-12 10:18 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-arm-kernel, Dan Williams, Sascha Hauer
When loading the microcode to the SDMA engine we have to use
the ram_code_start_addr found in the firmware image. The copy
in the sdma engine is not initialized correctly. This is broken
since:
5b28aa3 dmaengine i.MX SDMA: Allow to run without firmware
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/dma/imx-sdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index d5a5d4d..75df8b9 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1135,7 +1135,7 @@ static int __init sdma_get_firmware(struct sdma_engine *sdma,
/* download the RAM image for SDMA */
sdma_load_script(sdma, ram_code,
header->ram_code_size,
- sdma->script_addrs->ram_code_start_addr);
+ addr->ram_code_start_addr);
clk_disable(sdma->clk);
sdma_add_scripts(sdma, addr);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine i.MX SDMA: Fix firmware loading
2011-01-12 10:18 ` [PATCH] dmaengine i.MX SDMA: Fix " Sascha Hauer
@ 2011-01-15 0:23 ` Dan Williams
0 siblings, 0 replies; 3+ messages in thread
From: Dan Williams @ 2011-01-15 0:23 UTC (permalink / raw)
To: Sascha Hauer; +Cc: linux-kernel, linux-arm-kernel
On Wed, Jan 12, 2011 at 2:18 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> When loading the microcode to the SDMA engine we have to use
> the ram_code_start_addr found in the firmware image. The copy
> in the sdma engine is not initialized correctly. This is broken
> since:
> 5b28aa3 dmaengine i.MX SDMA: Allow to run without firmware
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
I'll apply this to my 'fixes' branch once I rebase on top of rc1.
--
Dan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-15 0:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-12 10:18 dmaengine: Fix i.MX sdma firmware loading Sascha Hauer
2011-01-12 10:18 ` [PATCH] dmaengine i.MX SDMA: Fix " Sascha Hauer
2011-01-15 0:23 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).