* [PATCH] x86, hw_nmi: Move backtrace_mask declaration under ARCH_HAS_NMI_WATCHDOG.
@ 2010-11-07 7:41 Rakib Mullick
2010-11-08 14:41 ` Don Zickus
0 siblings, 1 reply; 2+ messages in thread
From: Rakib Mullick @ 2010-11-07 7:41 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, x86, LKML, H. Peter Anvin
backtrace_mask has been used under the code context of
ARCH_HAS_NMI_WATCHDOG. So put it into that context.
We were warned by the following warning:
arch/x86/kernel/apic/hw_nmi.c:21: warning: ‘backtrace_mask’ defined but not used
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---
diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index cefd694..62f6e1e 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -17,15 +17,16 @@
#include <linux/nmi.h>
#include <linux/module.h>
-/* For reliability, we're prepared to waste bits here. */
-static DECLARE_BITMAP(backtrace_mask, NR_CPUS) __read_mostly;
-
u64 hw_nmi_get_sample_period(void)
{
return (u64)(cpu_khz) * 1000 * 60;
}
#ifdef ARCH_HAS_NMI_WATCHDOG
+
+/* For reliability, we're prepared to waste bits here. */
+static DECLARE_BITMAP(backtrace_mask, NR_CPUS) __read_mostly;
+
void arch_trigger_all_cpu_backtrace(void)
{
int i;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86, hw_nmi: Move backtrace_mask declaration under ARCH_HAS_NMI_WATCHDOG.
2010-11-07 7:41 [PATCH] x86, hw_nmi: Move backtrace_mask declaration under ARCH_HAS_NMI_WATCHDOG Rakib Mullick
@ 2010-11-08 14:41 ` Don Zickus
0 siblings, 0 replies; 2+ messages in thread
From: Don Zickus @ 2010-11-08 14:41 UTC (permalink / raw)
To: Rakib Mullick; +Cc: Ingo Molnar, Thomas Gleixner, x86, LKML, H. Peter Anvin
On Sun, Nov 07, 2010 at 01:41:34PM +0600, Rakib Mullick wrote:
> backtrace_mask has been used under the code context of
> ARCH_HAS_NMI_WATCHDOG. So put it into that context.
> We were warned by the following warning:
>
> arch/x86/kernel/apic/hw_nmi.c:21: warning: ‘backtrace_mask’ defined but not used
Thanks, I'll pull that into my tree.
Cheers,
Don
>
>
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> ---
>
> diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
> index cefd694..62f6e1e 100644
> --- a/arch/x86/kernel/apic/hw_nmi.c
> +++ b/arch/x86/kernel/apic/hw_nmi.c
> @@ -17,15 +17,16 @@
> #include <linux/nmi.h>
> #include <linux/module.h>
>
> -/* For reliability, we're prepared to waste bits here. */
> -static DECLARE_BITMAP(backtrace_mask, NR_CPUS) __read_mostly;
> -
> u64 hw_nmi_get_sample_period(void)
> {
> return (u64)(cpu_khz) * 1000 * 60;
> }
>
> #ifdef ARCH_HAS_NMI_WATCHDOG
> +
> +/* For reliability, we're prepared to waste bits here. */
> +static DECLARE_BITMAP(backtrace_mask, NR_CPUS) __read_mostly;
> +
> void arch_trigger_all_cpu_backtrace(void)
> {
> int i;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-08 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-07 7:41 [PATCH] x86, hw_nmi: Move backtrace_mask declaration under ARCH_HAS_NMI_WATCHDOG Rakib Mullick
2010-11-08 14:41 ` Don Zickus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).