* [PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt_regs() as static
@ 2021-03-12 22:18 Souptick Joarder
2021-03-12 22:28 ` Zeng, Oak
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2021-03-12 22:18 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel,
Hawking.Zhang, Oak.Zeng, felix.kuehling, kevin1.wang, le.ma,
lijo.lazar
Cc: amd-gfx, dri-devel, linux-kernel, Souptick Joarder
Kernel test robot throws below warning ->
drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c:56:6: warning: no previous
prototype for 'mmhub_v1_7_setup_vm_pt_regs' [-Wmissing-prototypes]
Mark mmhub_v1_7_setup_vm_pt_regs() as static.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
index 4df0b73..ae7d8a1 100644
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
@@ -53,7 +53,7 @@ static u64 mmhub_v1_7_get_fb_location(struct amdgpu_device *adev)
return base;
}
-void mmhub_v1_7_setup_vm_pt_regs(struct amdgpu_device *adev, uint32_t vmid,
+static void mmhub_v1_7_setup_vm_pt_regs(struct amdgpu_device *adev, uint32_t vmid,
uint64_t page_table_base)
{
struct amdgpu_vmhub *hub = &adev->vmhub[AMDGPU_MMHUB_0];
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt_regs() as static
2021-03-12 22:18 [PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt_regs() as static Souptick Joarder
@ 2021-03-12 22:28 ` Zeng, Oak
0 siblings, 0 replies; 2+ messages in thread
From: Zeng, Oak @ 2021-03-12 22:28 UTC (permalink / raw)
To: Souptick Joarder, Deucher, Alexander, Koenig, Christian, airlied,
daniel, Zhang, Hawking, Kuehling, Felix, Wang, Kevin(Yang),
Ma, Le, Lazar, Lijo
Cc: amd-gfx, dri-devel, linux-kernel
[AMD Official Use Only - Internal Distribution Only]
Thank you Joarder for the fix. But this has already been fixed in our Alex's drm-next branch.
Regards,
Oak
On 2021-03-12, 5:19 PM, "Souptick Joarder" <jrdr.linux@gmail.com> wrote:
Kernel test robot throws below warning ->
drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c:56:6: warning: no previous
prototype for 'mmhub_v1_7_setup_vm_pt_regs' [-Wmissing-prototypes]
Mark mmhub_v1_7_setup_vm_pt_regs() as static.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
index 4df0b73..ae7d8a1 100644
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c
@@ -53,7 +53,7 @@ static u64 mmhub_v1_7_get_fb_location(struct amdgpu_device *adev)
return base;
}
-void mmhub_v1_7_setup_vm_pt_regs(struct amdgpu_device *adev, uint32_t vmid,
+static void mmhub_v1_7_setup_vm_pt_regs(struct amdgpu_device *adev, uint32_t vmid,
uint64_t page_table_base)
{
struct amdgpu_vmhub *hub = &adev->vmhub[AMDGPU_MMHUB_0];
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-12 22:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 22:18 [PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt_regs() as static Souptick Joarder
2021-03-12 22:28 ` Zeng, Oak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).