linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Zhu <hongxing.zhu@nxp.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: "jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [EXT] Re: [PATCH v3] mailbox: imx: add support for imx v1 mu
Date: Fri, 2 Aug 2019 03:24:16 +0000	[thread overview]
Message-ID: <AM0PR0402MB3570B875F7104A31BB2E3C518CD90@AM0PR0402MB3570.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAEnQRZCz=fu7-2PmH+RGgnRgzeDCeR+A+wPbhjq2wQ2CZ3oQYg@mail.gmail.com>

> -----Original Message-----
> From: Daniel Baluta <daniel.baluta@gmail.com>
> Sent: 2019年8月1日 22:47
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: jassisinghbrar@gmail.com; Oleksij Rempel <o.rempel@pengutronix.de>;
> Aisheng Dong <aisheng.dong@nxp.com>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; linux-arm-kernel
> <linux-arm-kernel@lists.infradead.org>; dl-linux-imx <linux-imx@nxp.com>
> Subject: [EXT] Re: [PATCH v3] mailbox: imx: add support for imx v1 mu
> 
> Hi Richard,
> 
> Thanks for the patch. Please always add linux-imx@nxp.com mailing list for imx
> related patches. I missed it.
> 
[Richard Zhu] Okay, roger that.

> Few comments inline.
> 
> Please also update in a separate patch attached to this series the devictree
> bindings doc Documentation/devicetree/bindings/mailbox/fsl,mu.txt
> by adding description for mx7ulp-mu
> 
> <snip>
[Richard Zhu] Okay, the binding doc would be added later.
> 
> > There is a version1.0 MU on i.MX7ULP platform.
> 
> space between version and 1.0
> 
[Richard Zhu] Okay.

> > One new version ID register is added, and it's offset is 0.
> > TRn registers are defined at the offset 0x20 ~ 0x2C.
> > RRn registers are defined at the offset 0x40 ~ 0x4C.
> > SR/CR registers are defined at 0x60/0x64.
> > Extend this driver to support it.
> 
> Do you have a little bit of history about MU versioning? So there was:
> 
> * version 0.5 on i.MX6-es
> * version 1.0 on i.MX7ULP
> 
> Next, is this 1.0 compatbile with i.MX8 right?
> 
[Richard Zhu] Only i.MX7ULP has the version 1.0 MU.
i.MX8 has the same version MU that i.MX6-es have.
IMHO, I don't know why design team do it this way.

> Also, can you please rebase your patch on my 2 bugfixes attached?
[Richard Zhu] Okay, no problem. I would send the v4 version out later after rebase your 2 bugfixes patches.
> 
> thanks,
> Daniel.

  reply	other threads:[~2019-08-02  3:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31  8:51 Richard Zhu
2019-08-01 14:47 ` Daniel Baluta
2019-08-02  3:24   ` Richard Zhu [this message]
2019-08-02  3:54 ` Daniel Baluta
2019-08-02  4:29   ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0402MB3570B875F7104A31BB2E3C518CD90@AM0PR0402MB3570.eurprd04.prod.outlook.com \
    --to=hongxing.zhu@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=daniel.baluta@gmail.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --subject='RE: [EXT] Re: [PATCH v3] mailbox: imx: add support for imx v1 mu' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).