* [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue
@ 2018-07-17 6:25 Pengbo Mu
2018-07-17 6:40 ` Greg Kroah-Hartman
2018-07-17 6:40 ` Greg Kroah-Hartman
0 siblings, 2 replies; 6+ messages in thread
From: Pengbo Mu @ 2018-07-17 6:25 UTC (permalink / raw)
To: Felipe Balbi, linux-kernel, linux-usb; +Cc: Greg Kroah-Hartman, yinbo.zhu
From: "yinbo.zhu" <yinbo.zhu@nxp.com>
Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
---
drivers/usb/phy/phy-fsl-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c
index 900875f..dcb531c 100644
--- a/drivers/usb/phy/phy-fsl-usb.c
+++ b/drivers/usb/phy/phy-fsl-usb.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0+
/*
- * Copyright (C) 2007,2008 Freescale semiconductor, Inc.
+ * Copyright 2007,2008 Freescale Semiconductor, Inc.
*
* Author: Li Yang <LeoLi@freescale.com>
* Jerry Huang <Chang-Ming.Huang@freescale.com>
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue
2018-07-17 6:25 [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue Pengbo Mu
@ 2018-07-17 6:40 ` Greg Kroah-Hartman
2018-07-17 6:40 ` Greg Kroah-Hartman
1 sibling, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-17 6:40 UTC (permalink / raw)
To: Pengbo Mu; +Cc: Felipe Balbi, linux-kernel, linux-usb, yinbo.zhu
On Tue, Jul 17, 2018 at 02:25:56PM +0800, Pengbo Mu wrote:
> From: "yinbo.zhu" <yinbo.zhu@nxp.com>
>
> Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
> ---
> drivers/usb/phy/phy-fsl-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c
> index 900875f..dcb531c 100644
> --- a/drivers/usb/phy/phy-fsl-usb.c
> +++ b/drivers/usb/phy/phy-fsl-usb.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0+
> /*
> - * Copyright (C) 2007,2008 Freescale semiconductor, Inc.
> + * Copyright 2007,2008 Freescale Semiconductor, Inc.
Huh? WHat exact "issue" are you fixing here? Be specific please.
And I can't take patches without any changelog text, sorry.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue
2018-07-17 6:25 [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue Pengbo Mu
2018-07-17 6:40 ` Greg Kroah-Hartman
@ 2018-07-17 6:40 ` Greg Kroah-Hartman
2018-07-17 7:16 ` Pengbo Mu
1 sibling, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-17 6:40 UTC (permalink / raw)
To: Pengbo Mu; +Cc: Felipe Balbi, linux-kernel, linux-usb, yinbo.zhu
On Tue, Jul 17, 2018 at 02:25:56PM +0800, Pengbo Mu wrote:
> From: "yinbo.zhu" <yinbo.zhu@nxp.com>
>
> Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
Also, you need to sign off on it, _and_ we need a valid name here for
the author and sign-off.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue
2018-07-17 6:40 ` Greg Kroah-Hartman
@ 2018-07-17 7:16 ` Pengbo Mu
2018-07-17 7:41 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Pengbo Mu @ 2018-07-17 7:16 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Felipe Balbi, linux-kernel, linux-usb
Hi Greg,
Sorry for missing the changelog text & sign .
BTW , it's my first send email to upstream.
Thanks for your advices.
Regards,
Pengbo Mu
-----Original Message-----
From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org]
Sent: 2018年7月17日 14:41
To: Pengbo Mu <pengbo.mu@nxp.com>
Cc: Felipe Balbi <balbi@kernel.org>; linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; Yinbo Zhu <yinbo.zhu@nxp.com>
Subject: Re: [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue
On Tue, Jul 17, 2018 at 02:25:56PM +0800, Pengbo Mu wrote:
> From: "yinbo.zhu" <yinbo.zhu@nxp.com>
>
> Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
Also, you need to sign off on it, _and_ we need a valid name here for the author and sign-off.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue
2018-07-17 7:16 ` Pengbo Mu
@ 2018-07-17 7:41 ` Greg Kroah-Hartman
2018-07-17 8:04 ` Pengbo Mu
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-17 7:41 UTC (permalink / raw)
To: Pengbo Mu; +Cc: Felipe Balbi, linux-kernel, linux-usb
On Tue, Jul 17, 2018 at 07:16:40AM +0000, Pengbo Mu wrote:
> Hi Greg,
>
> Sorry for missing the changelog text & sign .
> BTW , it's my first send email to upstream.
Do not make your first patch to a driver be a legal one, unless you have
a very strong legal background and can properly answer the questions
asked of such a change. Try doing real bug fixes instead.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue
2018-07-17 7:41 ` Greg Kroah-Hartman
@ 2018-07-17 8:04 ` Pengbo Mu
0 siblings, 0 replies; 6+ messages in thread
From: Pengbo Mu @ 2018-07-17 8:04 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi; +Cc: linux-kernel, linux-usb
Hi Felipe , Greg,
After our discussion , this patch would not been sent temporarily .
I'll pay more attention to learn the upsteam.
Thanks Felipe , Greg .
Regards,
Pengbo Mu
-----Original Message-----
From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org]
Sent: 2018年7月17日 15:42
To: Pengbo Mu <pengbo.mu@nxp.com>
Cc: Felipe Balbi <balbi@kernel.org>; linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue
On Tue, Jul 17, 2018 at 07:16:40AM +0000, Pengbo Mu wrote:
> Hi Greg,
>
> Sorry for missing the changelog text & sign .
> BTW , it's my first send email to upstream.
Do not make your first patch to a driver be a legal one, unless you have a very strong legal background and can properly answer the questions asked of such a change. Try doing real bug fixes instead.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-17 8:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 6:25 [PATCH] usb: phy: fix phy-fsl-usb.c's copyright issue Pengbo Mu
2018-07-17 6:40 ` Greg Kroah-Hartman
2018-07-17 6:40 ` Greg Kroah-Hartman
2018-07-17 7:16 ` Pengbo Mu
2018-07-17 7:41 ` Greg Kroah-Hartman
2018-07-17 8:04 ` Pengbo Mu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).