From: Leonard Crestez <leonard.crestez@nxp.com>
To: "Petr Štetiar" <ynezz@true.cz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes
Date: Tue, 7 May 2019 12:14:50 +0000 [thread overview]
Message-ID: <AM0PR04MB6434E06E7C43A2C95EB81F42EE310@AM0PR04MB6434.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 1557177887-30446-1-git-send-email-ynezz@true.cz
On 07.05.2019 00:25, Petr Štetiar wrote:
> Hi,
>
> this patch series is an attempt to fix the mess, I've somehow managed to
> introduce.
>
> First patch in this series is defacto v5 of the previous 05/10 patch in the
> series, but since the v4 of this 05/10 patch wasn't picked up by the
> patchwork for some unknown reason, this patch wasn't applied with the other
> 9 patches in the series, so I'm resending it as a separate patch of this
> fixup series again.
>
> Second patch is a result of this rebase against net-next tree, where I was
> checking again all current users of of_get_mac_address and found out, that
> there's new one in DSA, so I've converted this user to the new ERR_PTR
> encoded error value as well.
>
> Third patch which was sent as v5 wasn't considered for merge, but I still
> think, that we need to check for possible NULL value, thus current IS_ERR
> check isn't sufficient and we need to use IS_ERR_OR_NULL instead.
>
> Fourth patch fixes warning reported by kbuild test robot.
>
> Cheers,
>
> Petr
>
> Petr Štetiar (4):
> net: ethernet: support of_get_mac_address new ERR_PTR error
> net: dsa: support of_get_mac_address new ERR_PTR error
> staging: octeon-ethernet: Fix of_get_mac_address ERR_PTR check
> net: usb: smsc: fix warning reported by kbuild test robot
> drivers/net/ethernet/freescale/fec_main.c | 2 +-
This fixes netboot on imx (probably all of them).
Tested-by: Leonard Crestez <leonard.crestez@nxp.com>
But shouldn't "support of_get_mac_address new ERR_PTR error" somehow be
reordered so that it's done before allowing non-null errors from
of_get_mac_address?
Otherwise it will break bisect for many people.
--
Regards,
Leonard
next prev parent reply other threads:[~2019-05-07 12:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 21:24 [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes Petr Štetiar
2019-05-06 21:24 ` [PATCH net-next v2 2/4] net: dsa: support of_get_mac_address new ERR_PTR error Petr Štetiar
2019-05-07 13:49 ` Vladimir Oltean
2019-05-06 21:24 ` [PATCH net-next v2 3/4] staging: octeon-ethernet: Fix of_get_mac_address ERR_PTR check Petr Štetiar
2019-05-06 21:24 ` [PATCH net-next v2 4/4] net: usb: smsc: fix warning reported by kbuild test robot Petr Štetiar
2019-05-06 21:29 ` Woojung.Huh
2019-05-07 7:19 ` [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes Dan Carpenter
2019-05-07 7:41 ` Greg Kroah-Hartman
2019-05-07 8:39 ` Petr Štetiar
2019-05-07 9:01 ` netdev patchwork issues [Was: Re: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes] Petr Štetiar
2019-05-07 9:44 ` [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes Dan Carpenter
2019-05-07 9:07 ` Geert Uytterhoeven
2019-05-07 12:14 ` Leonard Crestez [this message]
2019-05-07 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB6434E06E7C43A2C95EB81F42EE310@AM0PR04MB6434.eurprd04.prod.outlook.com \
--to=leonard.crestez@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).