From: <Woojung.Huh@microchip.com>
To: <ynezz@true.cz>, <netdev@vger.kernel.org>, <davem@davemloft.net>,
<steve.glendinning@shawell.net>, <UNGLinuxDriver@microchip.com>
Cc: <andrew@lunn.ch>, <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
<frowand.list@gmail.com>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<maxime.ripard@bootlin.com>, <linux-usb@vger.kernel.org>
Subject: RE: [PATCH net-next v2 4/4] net: usb: smsc: fix warning reported by kbuild test robot
Date: Mon, 6 May 2019 21:29:18 +0000 [thread overview]
Message-ID: <DM5PR1101MB21399FAD9C7E072F24207C14E7300@DM5PR1101MB2139.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1557177887-30446-5-git-send-email-ynezz@true.cz>
> This patch fixes following warning reported by kbuild test robot:
>
> In function ‘memcpy’,
> inlined from ‘smsc75xx_init_mac_address’ at drivers/net/usb/smsc75xx.c:778:3,
> inlined from ‘smsc75xx_bind’ at drivers/net/usb/smsc75xx.c:1501:2:
> ./include/linux/string.h:355:9: warning: argument 2 null where non-null expected [-Wnonnull]
> return __builtin_memcpy(p, q, size);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/usb/smsc75xx.c: In function ‘smsc75xx_bind’:
> ./include/linux/string.h:355:9: note: in a call to built-in function ‘__builtin_memcpy’
>
> I've replaced the offending memcpy with ether_addr_copy, because I'm
> 100% sure, that of_get_mac_address can't return NULL as it returns valid
> pointer or ERR_PTR encoded value, nothing else.
>
> I'm hesitant to just change IS_ERR into IS_ERR_OR_NULL check, as this
> would make the warning disappear also, but it would be confusing to
> check for impossible return value just to make a compiler happy.
>
> Fixes: adfb3cb2c52e ("net: usb: support of_get_mac_address new ERR_PTR error")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Petr Štetiar <ynezz@true.cz>
> ---
Reviewed-by: Woojung Huh <woojung.huh@microchip.com>
next prev parent reply other threads:[~2019-05-06 21:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 21:24 [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes Petr Štetiar
2019-05-06 21:24 ` [PATCH net-next v2 2/4] net: dsa: support of_get_mac_address new ERR_PTR error Petr Štetiar
2019-05-07 13:49 ` Vladimir Oltean
2019-05-06 21:24 ` [PATCH net-next v2 3/4] staging: octeon-ethernet: Fix of_get_mac_address ERR_PTR check Petr Štetiar
2019-05-06 21:24 ` [PATCH net-next v2 4/4] net: usb: smsc: fix warning reported by kbuild test robot Petr Štetiar
2019-05-06 21:29 ` Woojung.Huh [this message]
2019-05-07 7:19 ` [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes Dan Carpenter
2019-05-07 7:41 ` Greg Kroah-Hartman
2019-05-07 8:39 ` Petr Štetiar
2019-05-07 9:01 ` netdev patchwork issues [Was: Re: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes] Petr Štetiar
2019-05-07 9:44 ` [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes Dan Carpenter
2019-05-07 9:07 ` Geert Uytterhoeven
2019-05-07 12:14 ` Leonard Crestez
2019-05-07 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1101MB21399FAD9C7E072F24207C14E7300@DM5PR1101MB2139.namprd11.prod.outlook.com \
--to=woojung.huh@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).