* [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr()
@ 2020-09-21 13:10 Qinglang Miao
2020-09-21 13:18 ` Claudiu Manoil
2020-09-21 20:48 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Qinglang Miao @ 2020-09-21 13:10 UTC (permalink / raw)
To: Claudiu Manoil
Cc: David S. Miller, Jakub Kicinski, netdev, linux-kernel, Qinglang Miao
Simplify the return expression.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/net/ethernet/freescale/enetc/enetc_vf.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_vf.c b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
index f14576212..7b5c82c7e 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_vf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
@@ -78,16 +78,11 @@ static int enetc_vf_set_mac_addr(struct net_device *ndev, void *addr)
{
struct enetc_ndev_priv *priv = netdev_priv(ndev);
struct sockaddr *saddr = addr;
- int err;
if (!is_valid_ether_addr(saddr->sa_data))
return -EADDRNOTAVAIL;
- err = enetc_msg_vsi_set_primary_mac_addr(priv, saddr);
- if (err)
- return err;
-
- return 0;
+ return enetc_msg_vsi_set_primary_mac_addr(priv, saddr);
}
static int enetc_vf_set_features(struct net_device *ndev,
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr()
2020-09-21 13:10 [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr() Qinglang Miao
@ 2020-09-21 13:18 ` Claudiu Manoil
2020-09-21 20:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu Manoil @ 2020-09-21 13:18 UTC (permalink / raw)
To: Qinglang Miao; +Cc: David S. Miller, Jakub Kicinski, netdev, linux-kernel
>-----Original Message-----
>From: Qinglang Miao <miaoqinglang@huawei.com>
>Sent: Monday, September 21, 2020 4:10 PM
>To: Claudiu Manoil <claudiu.manoil@nxp.com>
>Cc: David S. Miller <davem@davemloft.net>; Jakub Kicinski
><kuba@kernel.org>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
>Qinglang Miao <miaoqinglang@huawei.com>
>Subject: [PATCH -next] enetc: simplify the return expression of
>enetc_vf_set_mac_addr()
>
>Simplify the return expression.
>
>Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr()
2020-09-21 13:10 [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr() Qinglang Miao
2020-09-21 13:18 ` Claudiu Manoil
@ 2020-09-21 20:48 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-21 20:48 UTC (permalink / raw)
To: miaoqinglang; +Cc: claudiu.manoil, kuba, netdev, linux-kernel
From: Qinglang Miao <miaoqinglang@huawei.com>
Date: Mon, 21 Sep 2020 21:10:26 +0800
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-21 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 13:10 [PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr() Qinglang Miao
2020-09-21 13:18 ` Claudiu Manoil
2020-09-21 20:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).