* [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
@ 2018-07-18 6:54 Anson Huang
2018-07-19 3:20 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Anson Huang @ 2018-07-18 6:54 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland,
linux-arm-kernel, devicetree, linux-kernel
Cc: Linux-imx
Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
this patch adds it.
Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm/boot/dts/imx7d.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 9a772fc..30a1a73 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -9,6 +9,11 @@
/ {
cpus {
cpu0: cpu@0 {
+ operating-points = <
+ /* KHz uV */
+ 996000 1075000
+ 792000 975000
+ >;
clock-frequency = <996000000>;
operating-points-v2 = <&cpu0_opp_table>;
#cooling-cells = <2>;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
2018-07-18 6:54 [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0 Anson Huang
@ 2018-07-19 3:20 ` Shawn Guo
2018-07-19 3:24 ` Viresh Kumar
2018-07-19 8:29 ` Anson Huang
0 siblings, 2 replies; 6+ messages in thread
From: Shawn Guo @ 2018-07-19 3:20 UTC (permalink / raw)
To: Anson Huang, Viresh Kumar
Cc: s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland,
linux-arm-kernel, devicetree, linux-kernel, Linux-imx
On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> this patch adds it.
>
> Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
In general, when you send a patch fixing a commit, you should have the
author of that commit copied. I added Viresh here.
It looks like a wrong fix to me. It seems that commit b97872d4eb22
shouldn't change imx7d.dtsi at all. So the correct fix would be
reverting the change on imx7d.dtsi, @Viresh?
Shawn
> ---
> arch/arm/boot/dts/imx7d.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 9a772fc..30a1a73 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -9,6 +9,11 @@
> / {
> cpus {
> cpu0: cpu@0 {
> + operating-points = <
> + /* KHz uV */
> + 996000 1075000
> + 792000 975000
> + >;
> clock-frequency = <996000000>;
> operating-points-v2 = <&cpu0_opp_table>;
> #cooling-cells = <2>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
2018-07-19 3:20 ` Shawn Guo
@ 2018-07-19 3:24 ` Viresh Kumar
2018-07-19 3:26 ` Shawn Guo
2018-07-19 8:29 ` Anson Huang
1 sibling, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2018-07-19 3:24 UTC (permalink / raw)
To: Shawn Guo
Cc: Anson Huang, s.hauer, kernel, fabio.estevam, robh+dt,
mark.rutland, linux-arm-kernel, devicetree, linux-kernel,
Linux-imx
On 19-07-18, 11:20, Shawn Guo wrote:
> On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> > this patch adds it.
> >
> > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> In general, when you send a patch fixing a commit, you should have the
> author of that commit copied. I added Viresh here.
>
> It looks like a wrong fix to me. It seems that commit b97872d4eb22
> shouldn't change imx7d.dtsi at all. So the correct fix would be
> reverting the change on imx7d.dtsi, @Viresh?
Wow! Can't believe such a stupid mistake got merged and no one noticed
:(
Please revert that patch and I will resend the right fix Shawn.
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
2018-07-19 3:24 ` Viresh Kumar
@ 2018-07-19 3:26 ` Shawn Guo
2018-07-19 3:32 ` Viresh Kumar
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2018-07-19 3:26 UTC (permalink / raw)
To: Viresh Kumar
Cc: Anson Huang, s.hauer, kernel, fabio.estevam, robh+dt,
mark.rutland, linux-arm-kernel, devicetree, linux-kernel,
Linux-imx
On Thu, Jul 19, 2018 at 08:54:54AM +0530, Viresh Kumar wrote:
> On 19-07-18, 11:20, Shawn Guo wrote:
> > On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > > added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> > > this patch adds it.
> > >
> > > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >
> > In general, when you send a patch fixing a commit, you should have the
> > author of that commit copied. I added Viresh here.
> >
> > It looks like a wrong fix to me. It seems that commit b97872d4eb22
> > shouldn't change imx7d.dtsi at all. So the correct fix would be
> > reverting the change on imx7d.dtsi, @Viresh?
>
> Wow! Can't believe such a stupid mistake got merged and no one noticed
> :(
>
> Please revert that patch and I will resend the right fix Shawn.
Please just send a incremental fix patch for that commit.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
2018-07-19 3:26 ` Shawn Guo
@ 2018-07-19 3:32 ` Viresh Kumar
0 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2018-07-19 3:32 UTC (permalink / raw)
To: Shawn Guo
Cc: Anson Huang, s.hauer, kernel, fabio.estevam, robh+dt,
mark.rutland, linux-arm-kernel, devicetree, linux-kernel,
Linux-imx
On 19-07-18, 11:26, Shawn Guo wrote:
> On Thu, Jul 19, 2018 at 08:54:54AM +0530, Viresh Kumar wrote:
> > On 19-07-18, 11:20, Shawn Guo wrote:
> > > On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > > > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > > > added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> > > > this patch adds it.
> > > >
> > > > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > >
> > > In general, when you send a patch fixing a commit, you should have the
> > > author of that commit copied. I added Viresh here.
> > >
> > > It looks like a wrong fix to me. It seems that commit b97872d4eb22
> > > shouldn't change imx7d.dtsi at all. So the correct fix would be
> > > reverting the change on imx7d.dtsi, @Viresh?
> >
> > Wow! Can't believe such a stupid mistake got merged and no one noticed
> > :(
> >
> > Please revert that patch and I will resend the right fix Shawn.
>
> Please just send a incremental fix patch for that commit.
Sure. Actually I almost wrote the patch but then realized that it
wouldn't be fair for me to send a patch for something Anson has been
working on.
@Anson: Please send a patch to remove the "operating-points" property.
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
2018-07-19 3:20 ` Shawn Guo
2018-07-19 3:24 ` Viresh Kumar
@ 2018-07-19 8:29 ` Anson Huang
1 sibling, 0 replies; 6+ messages in thread
From: Anson Huang @ 2018-07-19 8:29 UTC (permalink / raw)
To: Shawn Guo, Viresh Kumar
Cc: s.hauer, kernel, Fabio Estevam, robh+dt, mark.rutland,
linux-arm-kernel, devicetree, linux-kernel, dl-linux-imx
Hi, Shawn
Anson Huang
Best Regards!
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Thursday, July 19, 2018 11:20 AM
> To: Anson Huang <anson.huang@nxp.com>; Viresh Kumar
> <viresh.kumar@linaro.org>
> Cc: s.hauer@pengutronix.de; kernel@pengutronix.de; Fabio Estevam
> <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com;
> linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
>
> On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for
> > CPUs") added "operating-points" property for all CPUs, but missed
> > i.MX7D's cpu0, this patch adds it.
> >
> > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for
> > CPUs")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> In general, when you send a patch fixing a commit, you should have the author
> of that commit copied. I added Viresh here.
Thanks, I missed it.
>
> It looks like a wrong fix to me. It seems that commit b97872d4eb22 shouldn't
> change imx7d.dtsi at all. So the correct fix would be reverting the change on
> imx7d.dtsi, @Viresh?
Agreed, I think the arch/arm/boot/dts/imx7d.dtsi should NOT be changed, as it already
had operating-points-v2 on both CPUs, I sent out another new patch with correct fix,
please review it.
Thanks.
Anson.
>
> Shawn
>
> > ---
> > arch/arm/boot/dts/imx7d.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7d.dtsi
> > b/arch/arm/boot/dts/imx7d.dtsi index 9a772fc..30a1a73 100644
> > --- a/arch/arm/boot/dts/imx7d.dtsi
> > +++ b/arch/arm/boot/dts/imx7d.dtsi
> > @@ -9,6 +9,11 @@
> > / {
> > cpus {
> > cpu0: cpu@0 {
> > + operating-points = <
> > + /* KHz uV */
> > + 996000 1075000
> > + 792000 975000
> > + >;
> > clock-frequency = <996000000>;
> > operating-points-v2 = <&cpu0_opp_table>;
> > #cooling-cells = <2>;
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-19 8:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 6:54 [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0 Anson Huang
2018-07-19 3:20 ` Shawn Guo
2018-07-19 3:24 ` Viresh Kumar
2018-07-19 3:26 ` Shawn Guo
2018-07-19 3:32 ` Viresh Kumar
2018-07-19 8:29 ` Anson Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).