linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 7/7] thermal: qoriq: Add thermal management support
@ 2016-06-12  8:58 Hongtao Jia
  0 siblings, 0 replies; 3+ messages in thread
From: Hongtao Jia @ 2016-06-12  8:58 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, edubezval, rui.zhang, robh+dt, galak, Scott Wood,
	shawnguo, linux-pm, devicetree, linux-kernel, linuxppc-dev,
	linux-arm-kernel

Hi all,

I received this auto build error notice. I have something to clarify and ask:
- [cannot apply to robh/for-next soc-thermal/next]
   It could apply to robh/for-next.
   It could not apply to soc-thermal/next because this branch is not updated to the latest kernel.

- [auto build test ERROR on v4.7-rc1] [also build test ERROR on next-20160603]
   It passed all build test under ARCH=arm/powerpc/x86.
   The error log under ARCH=um "implicit declaration of function 'iounmap'" looks odd for me because
   I believe it's included in <linux/io.h>. Any suggestions for me to fix this issue?

Thanks.
- Hongtao


> -----邮件原件-----
> 发件人: kbuild test robot [mailto:lkp@intel.com]
> 发送时间: Monday, June 06, 2016 1:52 AM
> 收件人: Hongtao Jia <hongtao.jia@nxp.com>
> 抄送: kbuild-all@01.org; edubezval@gmail.com; rui.zhang@intel.com;
> robh+dt@kernel.org; galak@codeaurora.org; Scott Wood
> <scott.wood@nxp.com>; shawnguo@kernel.org; linux-pm@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; Hongtao Jia
> <hongtao.jia@nxp.com>
> 主题: Re: [PATCH 7/7] thermal: qoriq: Add thermal management support
> 
> Hi,
> 
> [auto build test ERROR on v4.7-rc1]
> [also build test ERROR on next-20160603]
> [cannot apply to robh/for-next soc-thermal/next]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Jia-Hongtao/dt-bindings-
> Update-QorIQ-TMU-thermal-bindings/20160603-154428
> config: um-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=um
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/thermal/qoriq_thermal.c: In function 'qoriq_tmu_probe':
> >> drivers/thermal/qoriq_thermal.c:255:2: error: implicit declaration of
> function 'iounmap' [-Werror=implicit-function-declaration]
>      iounmap(data->regs);
>      ^~~~~~~
>    cc1: some warnings being treated as errors
> 
> vim +/iounmap +255 drivers/thermal/qoriq_thermal.c
> 
>    249		site |= 0x1 << (15 - data->sensor_id);
>    250		tmu_write(data, site | TMR_ME | TMR_ALPF, &data->regs-
> >tmr);
>    251
>    252		return 0;
>    253
>    254	err_tmu:
>  > 255		iounmap(data->regs);
>    256
>    257	err_iomap:
>    258		platform_set_drvdata(pdev, NULL);
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH 1/7] dt-bindings: Update QorIQ TMU thermal bindings
@ 2016-06-03  6:57 Jia Hongtao
  2016-06-03  6:57 ` [PATCH 7/7] thermal: qoriq: Add thermal management support Jia Hongtao
  0 siblings, 1 reply; 3+ messages in thread
From: Jia Hongtao @ 2016-06-03  6:57 UTC (permalink / raw)
  To: edubezval, rui.zhang, robh+dt, galak, scott.wood, shawnguo
  Cc: linux-pm, devicetree, linux-kernel, linuxppc-dev,
	linux-arm-kernel, hongtao.jia

For different types of SoC the sensor id and endianness may vary.
"#thermal-sensor-cells" is used to provide sensor id information.
"little-endian" property is to tell the endianness of TMU.

Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
---
 .../devicetree/bindings/thermal/qoriq-thermal.txt     | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
index 66223d5..8eeef80 100644
--- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
@@ -1,22 +1,28 @@
 * Thermal Monitoring Unit (TMU) on Freescale QorIQ SoCs
 
 Required properties:
-- compatible : Must include "fsl,qoriq-tmu". The version of the device is
+- compatible: Must include "fsl,qoriq-tmu". The version of the device is
 	determined by the TMU IP Block Revision Register (IPBRR0) at
 	offset 0x0BF8.
-	Table of correspondences between IPBRR0 values and example  chips:
+	Table of correspondences between IPBRR0 values and example chips:
 		Value           Device
 		----------      -----
 		0x01900102      T1040
-- reg : Address range of TMU registers.
-- interrupts : Contains the interrupt for TMU.
-- fsl,tmu-range : The values to be programmed into TTRnCR, as specified by
+- reg: Address range of TMU registers.
+- interrupts: Contains the interrupt for TMU.
+- fsl,tmu-range: The values to be programmed into TTRnCR, as specified by
 	the SoC reference manual. The first cell is TTR0CR, the second is
 	TTR1CR, etc.
-- fsl,tmu-calibration : A list of cell pairs containing temperature
+- fsl,tmu-calibration: A list of cell pairs containing temperature
 	calibration data, as specified by the SoC reference manual.
 	The first cell of each pair is the value to be written to TTCFGR,
 	and the second is the value to be written to TSCFGR.
+- #thermal-sensor-cells: Must be 1. The sensor specifier is the monitoring
+	site ID, and represents the "n" in TRITSRn and TRATSRn.
+
+Optional property:
+- little-endian: If present, the TMU registers are little endian.  If absent,
+	the default is big endian.
 
 Example:
 
@@ -60,4 +66,5 @@ tmu@f0000 {
 
 			       0x00030000 0x00000012
 			       0x00030001 0x0000001d>;
+	#thermal-sensor-cells = <1>;
 };
-- 
2.1.0.27.g96db324

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-12  9:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-12  8:58 [PATCH 7/7] thermal: qoriq: Add thermal management support Hongtao Jia
  -- strict thread matches above, loose matches on Subject: below --
2016-06-03  6:57 [PATCH 1/7] dt-bindings: Update QorIQ TMU thermal bindings Jia Hongtao
2016-06-03  6:57 ` [PATCH 7/7] thermal: qoriq: Add thermal management support Jia Hongtao
2016-06-05 17:51   ` kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).