* [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"
@ 2017-04-21 7:02 Colin King
2017-04-25 6:09 ` Richard Zhu
2017-04-25 19:04 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2017-04-21 7:02 UTC (permalink / raw)
To: Richard Zhu, Lucas Stach, Bjorn Helgaas, linux-pci, linux-arm-kernel
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
trivial fix to spelling mistake in dev_err message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pci/dwc/pci-imx6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index 102edcf1e261..129717ae5022 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device *pdev)
imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
"pciephy");
if (IS_ERR(imx6_pcie->pciephy_reset)) {
- dev_err(dev, "Failed to get PCIEPHY reset contol\n");
+ dev_err(dev, "Failed to get PCIEPHY reset control\n");
return PTR_ERR(imx6_pcie->pciephy_reset);
}
imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps");
if (IS_ERR(imx6_pcie->apps_reset)) {
- dev_err(dev, "Failed to get PCIE APPS reset contol\n");
+ dev_err(dev, "Failed to get PCIE APPS reset control\n");
return PTR_ERR(imx6_pcie->apps_reset);
}
break;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"
2017-04-21 7:02 [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control" Colin King
@ 2017-04-25 6:09 ` Richard Zhu
2017-04-25 19:04 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Richard Zhu @ 2017-04-25 6:09 UTC (permalink / raw)
To: Colin King, Lucas Stach, Bjorn Helgaas, linux-pci, linux-arm-kernel
Cc: linux-kernel
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Friday, April 21, 2017 3:03 PM
> To: Richard Zhu <hongxing.zhu@nxp.com>; Lucas Stach
> <l.stach@pengutronix.de>; Bjorn Helgaas <bhelgaas@google.com>; linux-
> pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Subject: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"
>
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Richard Zhu <hongxing.Zhu@nxp.com>
Best Regards
hongxing zhu
Email: hongxing.zhu@nxp.com
> ---
> drivers/pci/dwc/pci-imx6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c index
> 102edcf1e261..129717ae5022 100644
> --- a/drivers/pci/dwc/pci-imx6.c
> +++ b/drivers/pci/dwc/pci-imx6.c
> @@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device
> *pdev)
> imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
> "pciephy");
> if (IS_ERR(imx6_pcie->pciephy_reset)) {
> - dev_err(dev, "Failed to get PCIEPHY reset contol\n");
> + dev_err(dev, "Failed to get PCIEPHY reset control\n");
> return PTR_ERR(imx6_pcie->pciephy_reset);
> }
>
> imx6_pcie->apps_reset = devm_reset_control_get(dev,
> "apps");
> if (IS_ERR(imx6_pcie->apps_reset)) {
> - dev_err(dev, "Failed to get PCIE APPS reset
> contol\n");
> + dev_err(dev, "Failed to get PCIE APPS reset
> control\n");
> return PTR_ERR(imx6_pcie->apps_reset);
> }
> break;
> --
> 2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"
2017-04-21 7:02 [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control" Colin King
2017-04-25 6:09 ` Richard Zhu
@ 2017-04-25 19:04 ` Bjorn Helgaas
2017-04-25 19:21 ` Joe Perches
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2017-04-25 19:04 UTC (permalink / raw)
To: Colin King
Cc: Richard Zhu, Lucas Stach, Bjorn Helgaas, linux-pci,
linux-arm-kernel, linux-kernel
On Fri, Apr 21, 2017 at 08:02:30AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied with Richard's ack to pci/host-imx6 for v4.12, thanks.
FWIW, there are about 25 other occurrences of "contol" in other parts
of the tree.
> ---
> drivers/pci/dwc/pci-imx6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
> index 102edcf1e261..129717ae5022 100644
> --- a/drivers/pci/dwc/pci-imx6.c
> +++ b/drivers/pci/dwc/pci-imx6.c
> @@ -726,13 +726,13 @@ static int imx6_pcie_probe(struct platform_device *pdev)
> imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
> "pciephy");
> if (IS_ERR(imx6_pcie->pciephy_reset)) {
> - dev_err(dev, "Failed to get PCIEPHY reset contol\n");
> + dev_err(dev, "Failed to get PCIEPHY reset control\n");
> return PTR_ERR(imx6_pcie->pciephy_reset);
> }
>
> imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps");
> if (IS_ERR(imx6_pcie->apps_reset)) {
> - dev_err(dev, "Failed to get PCIE APPS reset contol\n");
> + dev_err(dev, "Failed to get PCIE APPS reset control\n");
> return PTR_ERR(imx6_pcie->apps_reset);
> }
> break;
> --
> 2.11.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control"
2017-04-25 19:04 ` Bjorn Helgaas
@ 2017-04-25 19:21 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2017-04-25 19:21 UTC (permalink / raw)
To: Bjorn Helgaas, Colin King
Cc: Richard Zhu, Lucas Stach, Bjorn Helgaas, linux-pci,
linux-arm-kernel, linux-kernel
On Tue, 2017-04-25 at 14:04 -0500, Bjorn Helgaas wrote:
> On Fri, Apr 21, 2017 at 08:02:30AM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > trivial fix to spelling mistake in dev_err message
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Applied with Richard's ack to pci/host-imx6 for v4.12, thanks.
>
> FWIW, there are about 25 other occurrences of "contol" in other parts
> of the tree.
Colin seems to focus on the logging format strings and
not code comments.
Other than these 2, there are 28 other instances in -next.
All of them are not output anywhere, these are just source
code comments.
$ git grep -w -i -E "contoller|contol" | wc -l
30
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-25 19:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-21 7:02 [PATCH] PCI: imx6: fix spelling mistake: "contol" -> "control" Colin King
2017-04-25 6:09 ` Richard Zhu
2017-04-25 19:04 ` Bjorn Helgaas
2017-04-25 19:21 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).