* RE: [PATCH v2 1/2] arm64: dts: imx8mm-evk: correct ldo1/ldo2 voltage range
2020-05-21 14:17 [PATCH v2 1/2] arm64: dts: imx8mm-evk: correct ldo1/ldo2 voltage range Robin Gong
@ 2020-05-21 10:51 ` Aisheng Dong
2020-05-21 14:17 ` [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: " Robin Gong
1 sibling, 0 replies; 6+ messages in thread
From: Aisheng Dong @ 2020-05-21 10:51 UTC (permalink / raw)
To: Robin Gong, robh+dt, shawnguo, s.hauer, festevam, Anson Huang, Peng Fan
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, dl-linux-imx
> From: Robin Gong <yibin.gong@nxp.com>
> Sent: Thursday, May 21, 2020 10:18 PM
>
> Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low group
> (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage groups have
> been supported at bd718x7-regulator driver, hence, just corrrect the voltage
> range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range too.
> Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate i.mx8mm
> datasheet as the below warning log in kernel:
>
> [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV
> [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV
>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: correct ldo1/ldo2 voltage range
2020-05-21 14:17 ` [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: " Robin Gong
@ 2020-05-21 10:51 ` Aisheng Dong
2020-05-22 1:36 ` Fabio Estevam
1 sibling, 0 replies; 6+ messages in thread
From: Aisheng Dong @ 2020-05-21 10:51 UTC (permalink / raw)
To: Robin Gong, robh+dt, shawnguo, s.hauer, festevam, Anson Huang, Peng Fan
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, dl-linux-imx
> From: Robin Gong <yibin.gong@nxp.com>
> Sent: Thursday, May 21, 2020 10:18 PM
>
> Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low group
> (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage groups have
> been supported at bd718x7-regulator driver, hence, just corrrect the voltage
> range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range too.
> Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate i.mx8mn
> datasheet as the below warning log in kernel:
>
> [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV
> [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV
>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] arm64: dts: imx8mm-evk: correct ldo1/ldo2 voltage range
@ 2020-05-21 14:17 Robin Gong
2020-05-21 10:51 ` Aisheng Dong
2020-05-21 14:17 ` [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: " Robin Gong
0 siblings, 2 replies; 6+ messages in thread
From: Robin Gong @ 2020-05-21 14:17 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, festevam, anson.huang, peng.fan
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, linux-imx
Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low group
(1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage groups
have been supported at bd718x7-regulator driver, hence, just corrrect the
voltage range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range too.
Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate i.mx8mm
datasheet as the below warning log in kernel:
[ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV
[ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index e5ec832..0f1d7f8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -208,7 +208,7 @@
ldo1_reg: LDO1 {
regulator-name = "LDO1";
- regulator-min-microvolt = <3000000>;
+ regulator-min-microvolt = <1600000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
@@ -216,7 +216,7 @@
ldo2_reg: LDO2 {
regulator-name = "LDO2";
- regulator-min-microvolt = <900000>;
+ regulator-min-microvolt = <800000>;
regulator-max-microvolt = <900000>;
regulator-boot-on;
regulator-always-on;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: correct ldo1/ldo2 voltage range
2020-05-21 14:17 [PATCH v2 1/2] arm64: dts: imx8mm-evk: correct ldo1/ldo2 voltage range Robin Gong
2020-05-21 10:51 ` Aisheng Dong
@ 2020-05-21 14:17 ` Robin Gong
2020-05-21 10:51 ` Aisheng Dong
2020-05-22 1:36 ` Fabio Estevam
1 sibling, 2 replies; 6+ messages in thread
From: Robin Gong @ 2020-05-21 14:17 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, festevam, anson.huang, peng.fan
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, linux-imx
Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low group
(1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage groups
have been supported at bd718x7-regulator driver, hence, just corrrect the
voltage range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range too.
Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate i.mx8mn
datasheet as the below warning log in kernel:
[ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV
[ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index d07e0e6..a1e5483 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -113,7 +113,7 @@
ldo1_reg: LDO1 {
regulator-name = "LDO1";
- regulator-min-microvolt = <3000000>;
+ regulator-min-microvolt = <1600000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
@@ -121,7 +121,7 @@
ldo2_reg: LDO2 {
regulator-name = "LDO2";
- regulator-min-microvolt = <900000>;
+ regulator-min-microvolt = <800000>;
regulator-max-microvolt = <900000>;
regulator-boot-on;
regulator-always-on;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: correct ldo1/ldo2 voltage range
2020-05-21 14:17 ` [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: " Robin Gong
2020-05-21 10:51 ` Aisheng Dong
@ 2020-05-22 1:36 ` Fabio Estevam
2020-05-22 2:26 ` Robin Gong
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2020-05-22 1:36 UTC (permalink / raw)
To: Robin Gong
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Yongcai Huang, Peng Fan,
Sascha Hauer,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, NXP Linux Team
Hi Robin,
On Thu, May 21, 2020 at 3:17 AM Robin Gong <yibin.gong@nxp.com> wrote:
>
> Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low group
Please use capital letter V for Volt.
> (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage groups
> have been supported at bd718x7-regulator driver, hence, just corrrect the
> voltage range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range too.
> Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate i.mx8mn
> datasheet as the below warning log in kernel:
>
> [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV
> [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV
>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
You should add a Fixes tag and Cc stable on this one.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: correct ldo1/ldo2 voltage range
2020-05-22 1:36 ` Fabio Estevam
@ 2020-05-22 2:26 ` Robin Gong
0 siblings, 0 replies; 6+ messages in thread
From: Robin Gong @ 2020-05-22 2:26 UTC (permalink / raw)
To: Fabio Estevam
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Anson Huang, Peng Fan,
Sascha Hauer,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, dl-linux-imx
On 2020/05/22 Fabio Estevam <festevam@gmail.com> wrote:
> Hi Robin,
>
> On Thu, May 21, 2020 at 3:17 AM Robin Gong <yibin.gong@nxp.com> wrote:
> >
> > Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low
> > group
>
> Please use capital letter V for Volt.
>
> > (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage
> > groups have been supported at bd718x7-regulator driver, hence, just
> > corrrect the voltage range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range
> too.
> > Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate
> > i.mx8mn datasheet as the below warning log in kernel:
> >
> > [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV
> > [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV
> >
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
>
> You should add a Fixes tag and Cc stable on this one.
Okay, will address your comments in v3, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-22 2:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21 14:17 [PATCH v2 1/2] arm64: dts: imx8mm-evk: correct ldo1/ldo2 voltage range Robin Gong
2020-05-21 10:51 ` Aisheng Dong
2020-05-21 14:17 ` [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: " Robin Gong
2020-05-21 10:51 ` Aisheng Dong
2020-05-22 1:36 ` Fabio Estevam
2020-05-22 2:26 ` Robin Gong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).