From: Adam Ward <Adam.Ward.opensource@diasemi.com>
To: Rob Herring <robh@kernel.org>,
Adam Ward <Adam.Ward.opensource@diasemi.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [PATCH V4 01/10] regulator: Update DA9121 dt-bindings
Date: Tue, 8 Dec 2020 10:41:57 +0000 [thread overview]
Message-ID: <AM6PR10MB280786E90152D183C8B52454ECCD0@AM6PR10MB2807.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20201207175809.GA503826@robh.at.kernel.org>
On Mon, Dec 07, 2020 at 17:58PM, Rob Herring wrote:
> > + properties:
> > + regulator-mode:
> > + maxItems: 1
> > + description: Defined in include/dt-bindings/regulator/dlg,da9121-
> regulator.h
>
> 'regulator-mode' is defined as a property of a
> 'regulator-state-(standby|mem|disk)' child node. I don't see how you
> would use this with 'regulator-initial-mode' either.
>
> > +
> > + regulator-initial-mode:
> > + maxItems: 1
>
> 'maxItems' applies to arrays and this is not an array. What you should
> have is constraints on the values:
>
> enum: [ 0, 1, 2, 3 ]
OK, I see better now - would this be the valid way to scope them both?
properties:
regulator-state-(standby|mem|disk):
type: object
properties:
regulator-mode:
enum: [ 0, 1, 2, 3 ]
description: Defined in include/dt-bindings/regulator/dlg,da9121-regulator.h
regulator-initial-mode:
enum: [ 0, 1, 2, 3 ]
description: Defined in include/dt-bindings/regulator/dlg,da9121-regulator.h
I couldn't find a precedent in regulator yaml, and it's far removed enough from what
I see in the abstract JSON-schema documentation to make relating them tricky, even
if I had sufficient familiarity with the terminology to believe I'd properly understood that!
Perhaps I'd be better off abandoning this attempt, and just having the regulator
description mention these properties/file, like the texts for act8865 and max77802 do?
next prev parent reply other threads:[~2020-12-08 10:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 13:52 [PATCH V4 00/10] regulator: da9121: extend support to variants, add features Adam Ward
2020-12-01 13:52 ` [PATCH V4 01/10] regulator: Update DA9121 dt-bindings Adam Ward
2020-12-07 17:58 ` Rob Herring
2020-12-08 10:41 ` Adam Ward [this message]
2020-12-01 13:52 ` [PATCH V4 02/10] regulator: da9121: Add header file Adam Ward
2020-12-01 13:52 ` [PATCH V4 03/10] regulator: da9121: Add device variants Adam Ward
2020-12-01 13:52 ` [PATCH V4 04/10] regulator: da9121: Add device variant regmaps Adam Ward
2020-12-01 13:52 ` [PATCH V4 05/10] regulator: da9121: Add device variant descriptors Adam Ward
2020-12-01 13:52 ` [PATCH V4 06/10] regulator: da9121: Add support for device variants via devicetree Adam Ward
2020-12-01 13:52 ` [PATCH V4 07/10] regulator: da9121: Update registration to support multiple buck variants Adam Ward
2020-12-01 13:52 ` [PATCH V4 08/10] regulator: da9121: add current support Adam Ward
2020-12-01 13:52 ` [PATCH V4 09/10] regulator: da9121: add mode support Adam Ward
2020-12-01 13:52 ` [PATCH V4 10/10] regulator: da9121: add interrupt support Adam Ward
2020-12-01 14:01 ` [PATCH V4 00/10] regulator: da9121: extend support to variants, add features Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR10MB280786E90152D183C8B52454ECCD0@AM6PR10MB2807.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.ward.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).