From: Shenwei Wang <shenwei.wang@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"brgl@bgdev.pl" <brgl@bgdev.pl>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver
Date: Fri, 5 Aug 2022 12:31:09 +0000 [thread overview]
Message-ID: <AM9PR04MB82747C5078B14A22B98DB15D899E9@AM9PR04MB8274.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <c3060197-ef5c-ad41-1c18-9d39641d1ad6@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, August 5, 2022 1:57 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; brgl@bgdev.pl;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver
>
> Caution: EXT Email
>
> On 04/08/2022 20:49, Shenwei Wang wrote:
> > The SCU firmware on i.MX8 platforms provides a set of APIs to control
> > the GPIO PINs on the SCU domain. This patch implements the standard
> > GPIO driver interface to access those PINs on the SCU domain over the
> > SCU APIs.
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
> > ---
> > drivers/firmware/imx/Kconfig | 6 ++
> > drivers/firmware/imx/Makefile | 1 +
> > drivers/firmware/imx/imx-scu-gpio.c | 139
> > ++++++++++++++++++++++++++++
> > 3 files changed, 146 insertions(+)
> > create mode 100644 drivers/firmware/imx/imx-scu-gpio.c
> >
> > diff --git a/drivers/firmware/imx/Kconfig
> > b/drivers/firmware/imx/Kconfig index c027d99f2a59..484c13f3149a 100644
> > --- a/drivers/firmware/imx/Kconfig
> > +++ b/drivers/firmware/imx/Kconfig
> > @@ -28,3 +28,9 @@ config IMX_SCU_PD
> > depends on IMX_SCU
> > help
> > The System Controller Firmware (SCFW) based power domain driver.
> > +
> > +config IMX_SCU_GPIO
> > + def_bool y
> > + depends on IMX_SCU
> > + help
> > + Say Y here to enable the imx8 gpio over SCFW MISC API
>
> gpio driver go to drivers/gpio/
I was thinking to put the driver under drivers/gpio at the beginning too. Are there any requirements to put a driver under firmware directory?
Thanks,
Shenwei
>
> Best regards,
> Krzysztof
prev parent reply other threads:[~2022-08-05 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 18:49 [PATCH v1 0/3] Add IMX8 SCU GPIO support Shenwei Wang
2022-08-04 18:49 ` [PATCH v1 1/3] dt-bindings: gpio: Add imx-scu gpio driver bindings Shenwei Wang
2022-08-04 19:50 ` Rob Herring
2022-08-05 6:55 ` Krzysztof Kozlowski
2022-08-04 18:49 ` [PATCH v1 2/3] dt-bindings: firmware: imx: Add imx-scu gpio node Shenwei Wang
2022-08-05 6:56 ` Krzysztof Kozlowski
2022-08-05 12:49 ` [EXT] " Shenwei Wang
2022-08-08 7:52 ` Marco Felsch
2022-08-04 18:49 ` [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver Shenwei Wang
2022-08-05 6:57 ` Krzysztof Kozlowski
2022-08-05 12:31 ` Shenwei Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR04MB82747C5078B14A22B98DB15D899E9@AM9PR04MB8274.eurprd04.prod.outlook.com \
--to=shenwei.wang@nxp.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).