From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shenwei Wang <shenwei.wang@nxp.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linus.walleij@linaro.org, brgl@bgdev.pl, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/3] dt-bindings: gpio: Add imx-scu gpio driver bindings
Date: Fri, 5 Aug 2022 08:55:47 +0200 [thread overview]
Message-ID: <e75a09d1-d4b5-628e-e257-911f7d0f7097@linaro.org> (raw)
In-Reply-To: <20220804184908.470216-2-shenwei.wang@nxp.com>
On 04/08/2022 20:49, Shenwei Wang wrote:
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,imx8-scu-gpio
> +
> + "#gpio-cells":
> + const: 2
> +
> + gpio-controller: true
> +
> +required:
> + - compatible
> + - "#gpio-cells"
> + - gpio-controller
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gpio@scu {
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-05 6:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 18:49 [PATCH v1 0/3] Add IMX8 SCU GPIO support Shenwei Wang
2022-08-04 18:49 ` [PATCH v1 1/3] dt-bindings: gpio: Add imx-scu gpio driver bindings Shenwei Wang
2022-08-04 19:50 ` Rob Herring
2022-08-05 6:55 ` Krzysztof Kozlowski [this message]
2022-08-04 18:49 ` [PATCH v1 2/3] dt-bindings: firmware: imx: Add imx-scu gpio node Shenwei Wang
2022-08-05 6:56 ` Krzysztof Kozlowski
2022-08-05 12:49 ` [EXT] " Shenwei Wang
2022-08-08 7:52 ` Marco Felsch
2022-08-04 18:49 ` [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver Shenwei Wang
2022-08-05 6:57 ` Krzysztof Kozlowski
2022-08-05 12:31 ` [EXT] " Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e75a09d1-d4b5-628e-e257-911f7d0f7097@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).