From: Leo Li <leoyang.li@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Biwen Li <biwen.li@nxp.com>
Subject: RE: [PATCH v2 2/8] arm64: dts: ls1028a: add ftm_alarm1 node to be used as wakeup source
Date: Tue, 14 Dec 2021 06:16:34 +0000 [thread overview]
Message-ID: <AS8PR04MB89463CB1B95BD7C4333BE7DC8F759@AS8PR04MB8946.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20211214054619.GI10916@dragon>
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Tuesday, December 14, 2021 1:46 PM
> To: Leo Li <leoyang.li@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> Biwen Li <biwen.li@nxp.com>
> Subject: Re: [PATCH v2 2/8] arm64: dts: ls1028a: add ftm_alarm1 node to be
> used as wakeup source
>
> On Fri, Dec 03, 2021 at 06:17:12PM -0600, Li Yang wrote:
> > From: Biwen Li <biwen.li@nxp.com>
> >
> > Add flextimer2 based ftm_alarm1 node and enable it to be the default
> > rtc wakeup source for rdb and qds boards instead of the original
> > flextimer1 based ftm_alarm0. The ftm_alarm0 node hence is disabled by
> default.
>
> What's wrong with using ftm_alarm0?
Not 100% sure, but probably because we need to use flextimer1 as PWM.
Biwen, Can you comment?
>
> Shawn
>
> >
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 6 +++++-
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 6 +++++-
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 9 +++++++++
> > 3 files changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index 6e2a1da662fb..00d5b81bdef3 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -25,7 +25,7 @@ aliases {
> > serial1 = &duart1;
> > mmc0 = &esdhc;
> > mmc1 = &esdhc1;
> > - rtc1 = &ftm_alarm0;
> > + rtc1 = &ftm_alarm1;
> > };
> >
> > chosen {
> > @@ -234,6 +234,10 @@ mt35xu02g0: flash@0 {
> > };
> > };
> >
> > +&ftm_alarm1 {
> > + status = "okay";
> > +};
> > +
> > &i2c0 {
> > status = "okay";
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > index 7719f44bcaed..41900d351a92 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > @@ -21,7 +21,7 @@ aliases {
> > serial1 = &duart1;
> > mmc0 = &esdhc;
> > mmc1 = &esdhc1;
> > - rtc1 = &ftm_alarm0;
> > + rtc1 = &ftm_alarm1;
> > };
> >
> > chosen {
> > @@ -132,6 +132,10 @@ mt35xu02g0: flash@0 {
> > };
> > };
> >
> > +&ftm_alarm1 {
> > + status = "okay";
> > +};
> > +
> > &i2c0 {
> > status = "okay";
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 9efcaf68578c..ef9d17df2afa 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -1198,6 +1198,15 @@ ftm_alarm0: timer@2800000 {
> > reg = <0x0 0x2800000 0x0 0x10000>;
> > fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000
> 0x0 0x0>;
> > interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> > + status = "disabled";
> > + };
> > +
> > + ftm_alarm1: timer@2810000 {
> > + compatible = "fsl,ls1028a-ftm-alarm";
> > + reg = <0x0 0x2810000 0x0 0x10000>;
> > + fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000
> 0x0 0x0>;
> > + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> > + status = "disabled";
> > };
> > };
> >
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2021-12-14 6:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 0:17 [PATCH v2 0/8] ls1028a device tree update Li Yang
2021-12-04 0:17 ` [PATCH v2 1/8] arm64: dts: ls1028a: Add PCIe EP nodes Li Yang
2021-12-14 5:42 ` Shawn Guo
2021-12-04 0:17 ` [PATCH v2 2/8] arm64: dts: ls1028a: add ftm_alarm1 node to be used as wakeup source Li Yang
2021-12-14 5:46 ` Shawn Guo
2021-12-14 6:16 ` Leo Li [this message]
2021-12-14 6:20 ` Biwen Li
2021-12-04 0:17 ` [PATCH v2 3/8] arm64: dts: ls1028a: add flextimer based pwm nodes Li Yang
2021-12-04 0:17 ` [PATCH v2 4/8] arm64: dts: ls1028a-rdb: reorder nodes to be alphabetic Li Yang
2021-12-04 0:17 ` [PATCH v2 5/8] arm64: dts: ls1028a-rdb: enable pwm0 Li Yang
2021-12-04 0:17 ` [PATCH v2 6/8] arm64: dts: ls1028a-qds: move rtc node to the correct i2c bus Li Yang
2021-12-14 5:48 ` Shawn Guo
2021-12-04 0:17 ` [PATCH v2 7/8] arm64: dts: ls1028a-qds: enable lpuart1 Li Yang
2021-12-04 12:01 ` Vladimir Oltean
2021-12-04 0:17 ` [PATCH v2 8/8] arm64: dts: ls1028a-qds: add overlays for various serdes protocols Li Yang
2021-12-14 7:21 ` Shawn Guo
2021-12-14 8:14 ` Leo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB89463CB1B95BD7C4333BE7DC8F759@AS8PR04MB8946.eurprd04.prod.outlook.com \
--to=leoyang.li@nxp.com \
--cc=biwen.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).