From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: "Luck, Tony" <tony.luck@intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Borislav Petkov <bp@suse.de>, Dave Hansen <dave.hansen@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"'dan.j.williams@intel.com'" <dan.j.williams@intel.com>,
"Kani, Toshimitsu" <toshi.kani@hpe.com>,
"Vaden, Tom (HPE Server OS Architecture)" <tom.vaden@hpe.com>
Subject: RE: [PATCH] mm/hwpoison: Clear PRESENT bit for kernel 1:1 mappings of poison pages
Date: Wed, 21 Jun 2017 19:47:57 +0000 [thread overview]
Message-ID: <AT5PR84MB0082AF4EDEB05999494CA62FABDA0@AT5PR84MB0082.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20170621175403.n5kssz32e2oizl7k@intel.com>
> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Luck, Tony
> Sent: Wednesday, June 21, 2017 12:54 PM
> To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Borislav Petkov <bp@suse.de>; Dave Hansen <dave.hansen@intel.com>;
> x86@kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org
(adding linux-nvdimm list in this reply)
> Subject: Re: [PATCH] mm/hwpoison: Clear PRESENT bit for kernel 1:1
> mappings of poison pages
>
> On Wed, Jun 21, 2017 at 02:12:27AM +0000, Naoya Horiguchi wrote:
>
> > We had better have a reverse operation of this to cancel the unmapping
> > when unpoisoning?
>
> When we have unpoisoning, we can add something. We don't seem to have
> an inverse function for "set_memory_np" to just flip the _PRESENT bit
> back on again. But it would be trivial to write a set_memory_pp().
>
> Since we'd be doing this after the poison has been cleared, we wouldn't
> need to play games with the address. We'd just use:
>
> set_memory_pp((unsigned long)pfn_to_kaddr(pfn), 1);
>
> -Tony
Persistent memory does have unpoisoning and would require this inverse
operation - see drivers/nvdimm/pmem.c pmem_clear_poison() and core.c
nvdimm_clear_poison().
---
Robert Elliott, HPE Persistent Memory
next prev parent reply other threads:[~2017-06-21 19:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 19:02 [PATCH] mm/hwpoison: Clear PRESENT bit for kernel 1:1 mappings of poison pages Luck, Tony
2017-06-19 18:01 ` Borislav Petkov
2017-06-21 17:47 ` Luck, Tony
2017-06-21 19:59 ` Elliott, Robert (Persistent Memory)
2017-06-21 20:19 ` Luck, Tony
2017-06-22 9:39 ` Borislav Petkov
2017-06-29 22:11 ` git send-email (w/o Cc: stable) Luck, Tony
2017-06-30 7:08 ` Borislav Petkov
2017-06-23 22:19 ` [PATCH] mm/hwpoison: Clear PRESENT bit for kernel 1:1 mappings of poison pages Elliott, Robert (Persistent Memory)
2017-06-27 22:04 ` Luck, Tony
2017-06-27 22:09 ` Dan Williams
2017-08-16 17:18 ` [PATCH-resend] " Luck, Tony
2017-08-17 10:19 ` [tip:x86/mm] x86/mm, " tip-bot for Tony Luck
2017-08-17 22:09 ` [PATCH-resend] " Andrew Morton
2017-08-17 22:29 ` Elliott, Robert (Persistent Memory)
2017-08-17 23:32 ` Luck, Tony
2017-06-21 2:12 ` [PATCH] " Naoya Horiguchi
2017-06-21 17:54 ` Luck, Tony
2017-06-21 19:47 ` Elliott, Robert (Persistent Memory) [this message]
2017-06-21 20:30 ` Luck, Tony
2017-06-23 5:07 ` Dan Williams
2017-06-23 20:59 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AT5PR84MB0082AF4EDEB05999494CA62FABDA0@AT5PR84MB0082.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tom.vaden@hpe.com \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).