From: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Brown <broonie@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"Kernel development list" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
USB list <linux-usb@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend
Date: Fri, 10 Jun 2016 08:58:41 +0000 [thread overview]
Message-ID: <B256D81BAE5131468A838E5D7A24364101650BA1DB@penmbx01> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1606081352250.2191-100000@iolanthe.rowland.org>
Hi Alan,
> -----Original Message-----
> From: Alan Stern [mailto:stern@rowland.harvard.edu]
> Sent: 2016年6月9日 3:14
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Ferre, Nicolas
> <Nicolas.FERRE@atmel.com>; Rob Herring <robh+dt@kernel.org>; Pawel Moll
> <pawel.moll@arm.com>; Mark Brown <broonie@kernel.org>; Ian Campbell
> <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>;
> Alexandre Belloni <alexandre.belloni@free-electrons.com>; Kernel development
> list <linux-kernel@vger.kernel.org>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; USB list <linux-usb@vger.kernel.org>
> Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB
> suspend
>
> On Wed, 8 Jun 2016, Wenyou Yang wrote:
>
> > In order to the save power consumption, as a workaround, suspend
> > forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI
> > Interrupt Configuration Register in the SFRs while OHCI USB suspend.
> >
> > This suspend operation must be done before the USB clock is disabled,
> > resume after the USB clock is enabled.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
>
> You never answered the questions I posted for the first version of this
> patch:
>
> What does this mean? What does suspending a port do? Is it the same as a
> normal USB port suspend?
>
> If it is the same, why doesn't the USB_PORT_FEAT_SUSPEND subcase of the
> SetPortFeature case in ohci_hub_control() already take care of this?
I remembered I answered your questions, http://lists.infradead.org/pipermail/linux-arm-kernel/2016-May/429245.html
Maybe not very clear.
>
> Alan Stern
Best Regards,
Wenyou Yang
next prev parent reply other threads:[~2016-06-10 8:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 4:15 [PATCH v3 0/2] ARM: ohci-at91: Add support to forcibly suspend ports while sleep Wenyou Yang
2016-06-08 4:15 ` [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Wenyou Yang
2016-06-08 10:04 ` Nicolas Ferre
2016-06-08 10:45 ` Nicolas Ferre
2016-06-20 7:49 ` Yang, Wenyou
2016-06-08 19:13 ` Alan Stern
2016-06-10 8:58 ` Yang, Wenyou [this message]
2016-06-08 20:26 ` Rob Herring
2016-06-08 20:38 ` Alexandre Belloni
2016-06-17 13:44 ` Yang, Wenyou
2016-06-17 13:54 ` Alexandre Belloni
2016-06-20 3:16 ` Yang, Wenyou
2016-06-20 8:03 ` Alexandre Belloni
2016-06-20 8:46 ` Yang, Wenyou
2016-06-20 8:52 ` Alexandre Belloni
2016-06-20 9:21 ` Nicolas Ferre
2016-06-20 7:42 ` Yang, Wenyou
2016-06-08 4:15 ` [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node Wenyou Yang
2016-06-08 10:06 ` Nicolas Ferre
2016-06-08 10:33 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B256D81BAE5131468A838E5D7A24364101650BA1DB@penmbx01 \
--to=wenyou.yang@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).