From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Wenyou Yang <wenyou.yang@atmel.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Brown <broonie@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node
Date: Wed, 8 Jun 2016 12:33:00 +0200 [thread overview]
Message-ID: <20160608103300.GE2466@piout.net> (raw)
In-Reply-To: <5757EE13.1080107@atmel.com>
On 08/06/2016 at 12:06:11 +0200, Nicolas Ferre wrote :
> Le 08/06/2016 06:15, Wenyou Yang a écrit :
> > Use compatible "atmel,sama5d2-ohci" to be capable of suspending
> > ports while sleep to save the power consumption.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> > Changes in v3: None
> > Changes in v2:
> > - Use the new compatible for ohci-node.
> >
> > arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> > index 78996bd..03d6724 100644
> > --- a/arch/arm/boot/dts/sama5d2.dtsi
> > +++ b/arch/arm/boot/dts/sama5d2.dtsi
> > @@ -232,7 +232,7 @@
> > };
> >
> > usb1: ohci@00400000 {
> > - compatible = "atmel,at91rm9200-ohci", "usb-ohci";
> > + compatible = "atmel,sama5d2-ohci", "usb-ohci";
>
> We must change this to:
> + compatible = "atmel,sama5d2-ohci", "atmel,at91rm9200-ohci", "usb-ohci";
>
> To make it independent from the one that may reach Mainline through the USB git tree.
>
Well, like discussed, I'd say that a new compatible is not needed as we
already know on which chip we are running depending on the SFR that we
can lookup. My concern was only to avoid calling a function
unnecessarily on !sama5d2 platforms.
>
> > reg = <0x00400000 0x100000>;
> > interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>;
> > clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
> >
>
> Bye,
> --
> Nicolas Ferre
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-06-08 10:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 4:15 [PATCH v3 0/2] ARM: ohci-at91: Add support to forcibly suspend ports while sleep Wenyou Yang
2016-06-08 4:15 ` [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Wenyou Yang
2016-06-08 10:04 ` Nicolas Ferre
2016-06-08 10:45 ` Nicolas Ferre
2016-06-20 7:49 ` Yang, Wenyou
2016-06-08 19:13 ` Alan Stern
2016-06-10 8:58 ` Yang, Wenyou
2016-06-08 20:26 ` Rob Herring
2016-06-08 20:38 ` Alexandre Belloni
2016-06-17 13:44 ` Yang, Wenyou
2016-06-17 13:54 ` Alexandre Belloni
2016-06-20 3:16 ` Yang, Wenyou
2016-06-20 8:03 ` Alexandre Belloni
2016-06-20 8:46 ` Yang, Wenyou
2016-06-20 8:52 ` Alexandre Belloni
2016-06-20 9:21 ` Nicolas Ferre
2016-06-20 7:42 ` Yang, Wenyou
2016-06-08 4:15 ` [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node Wenyou Yang
2016-06-08 10:06 ` Nicolas Ferre
2016-06-08 10:33 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608103300.GE2466@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).