(no subject)

[d binderman]

Hello there,

I just tried to compile the Linux Kernel version 2.6.11.12
with the gcc 4.0 compiler. The compiler said

drivers/net/depca.c:1829: warning: operation on 'i' may be undefined

The source code is

for (i = entry; i != end; i = (++i) & lp->txRingMask) {

I agree with the compiler. Better code is

for (i = entry; i != end; i = (i + 1) & lp->txRingMask) {

Regards

David Binderman

_________________________________________________________________
Be the first to hear what's new at MSN - sign up to our free newsletters! 
http://www.msn.co.uk/newsletters

Re:

[Andrew Morton]

"d binderman" <dcb314@hotmail.com> wrote:
>
> 
> Hello there,
> 
> I just tried to compile the Linux Kernel version 2.6.11.12
> with the gcc 4.0 compiler. The compiler said
> 
> drivers/net/depca.c:1829: warning: operation on 'i' may be undefined
> 
> The source code is
> 
> for (i = entry; i != end; i = (++i) & lp->txRingMask) {
> 
> I agree with the compiler. Better code is
> 
> for (i = entry; i != end; i = (i + 1) & lp->txRingMask) {
> 

Someone already fixed it.

		/* set up the buffer descriptors */
		len = (skb->len < ETH_ZLEN) ? ETH_ZLEN : skb->len;
		for (i = entry; i != end; i = (i+1) & lp->txRingMask) {