* Q: about struct task_struct
@ 2009-04-29 22:41 H Hartley Sweeten
0 siblings, 0 replies; only message in thread
From: H Hartley Sweeten @ 2009-04-29 22:41 UTC (permalink / raw)
To: linux-kernel
Hello all,
In struct task_struck, should set_child_tid and clear_child_tid
be int __user * or u32 __user *?
In include/linux/sched.h they are both int __user * but in
kernel/fork.c there is the following line:
u32 __user * tidptr = tsk->clear_child_tid;
This is causing a sparse warning:
warning: incorrect type in initializer (different signedness)
expected unsigned int [noderef] [usertype] <asn:1>*tidptr
got int [noderef] <asn:1>*clear_child_tid
It seems the struct should have them as u32 __user * since the
clone_flags are defined up to 0x80000000 (CLONE_IO).
Thanks,
Hartley
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-04-29 22:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-29 22:41 Q: about struct task_struct H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).