[PATCH] kernel/time/jiffies.c: local symbols should be static

[PATCH] kernel/time/jiffies.c: local symbols should be static

[H Hartley Sweeten]

The symbol 'clocksource_jiffies' is not exported and should be static.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: John Stultz <johnstul@us.ibm.com>

---

diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
index 5404a84..36d2d83 100644
--- a/kernel/time/jiffies.c
+++ b/kernel/time/jiffies.c
@@ -55,7 +55,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
 	return (cycle_t) jiffies;
 }
 
-struct clocksource clocksource_jiffies = {
+static struct clocksource clocksource_jiffies = {
 	.name		= "jiffies",
 	.rating		= 1, /* lowest valid rating*/
 	.read		= jiffies_read, 

Re: [PATCH] kernel/time/jiffies.c: local symbols should be static

[john stultz]

On Mon, 2009-12-28 at 11:59 -0500, H Hartley Sweeten wrote:
> The symbol 'clocksource_jiffies' is not exported and should be static.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: John Stultz <johnstul@us.ibm.com>

Yep, clocksource_jiffies has stopped being used elsewhere, so this can
be cleaned up.

Acked-by: John Stultz <johnstul@us.ibm.com>

thanks
-john



> ---
> 
> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
> index 5404a84..36d2d83 100644
> --- a/kernel/time/jiffies.c
> +++ b/kernel/time/jiffies.c
> @@ -55,7 +55,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
>  	return (cycle_t) jiffies;
>  }
>  
> -struct clocksource clocksource_jiffies = {
> +static struct clocksource clocksource_jiffies = {
>  	.name		= "jiffies",
>  	.rating		= 1, /* lowest valid rating*/
>  	.read		= jiffies_read, 

[PATCH] kernel/time/jiffies.c: local symbols should be static

[H Hartley Sweeten]

The symbol 'clocksource_jiffies' is not used outside this file and
should be marked static.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Torben Hohn <torbenh@gmx.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>

---

diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
index a470154..60e3ff7 100644
--- a/kernel/time/jiffies.c
+++ b/kernel/time/jiffies.c
@@ -58,7 +58,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
 	return (cycle_t) jiffies;
 }
 
-struct clocksource clocksource_jiffies = {
+static struct clocksource clocksource_jiffies = {
 	.name		= "jiffies",
 	.rating		= 1, /* lowest valid rating*/
 	.read		= jiffies_read,

[PATCH] kernel/time/jiffies.c: local symbols should be static

[H Hartley Sweeten]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1188 bytes --]

The symbol 'clocksource_jiffies' is not exported and should be static.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: John Stultz <johnstul@us.ibm.com>

---

This patch was originally submitted on Dec 28, 2009 and appears to have
been lost.  John Stultz supplied the ack on Jan 4, 2010.

diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
index 5404a84..36d2d83 100644
--- a/kernel/time/jiffies.c
+++ b/kernel/time/jiffies.c
@@ -55,7 +55,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
 	return (cycle_t) jiffies;
 }
 
-struct clocksource clocksource_jiffies = {
+static struct clocksource clocksource_jiffies = {
 	.name		= "jiffies",
 	.rating		= 1, /* lowest valid rating*/
 	.read		= jiffies_read,

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email 
______________________________________________________________________
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥