* [PATCH] drivers/s390/net/qeth_l2_main.c: use %pM to shown MAC address
@ 2009-12-28 23:39 H Hartley Sweeten
2009-12-30 17:16 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2009-12-28 23:39 UTC (permalink / raw)
To: linux-kernel, netdev, linux-s390; +Cc: blaschka, David Miller
Use the %pM kernel extension to display the MAC address.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Cc: David S. Miller <davem@davemloft.net>
---
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index 0b76339..038299a 100644
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -486,22 +486,14 @@ static int qeth_l2_send_setmac_cb(struct qeth_card *card,
case IPA_RC_L2_DUP_MAC:
case IPA_RC_L2_DUP_LAYER3_MAC:
dev_warn(&card->gdev->dev,
- "MAC address "
- "%2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x "
- "already exists\n",
- card->dev->dev_addr[0], card->dev->dev_addr[1],
- card->dev->dev_addr[2], card->dev->dev_addr[3],
- card->dev->dev_addr[4], card->dev->dev_addr[5]);
+ "MAC address %pM already exists\n",
+ card->dev->dev_addr);
break;
case IPA_RC_L2_MAC_NOT_AUTH_BY_HYP:
case IPA_RC_L2_MAC_NOT_AUTH_BY_ADP:
dev_warn(&card->gdev->dev,
- "MAC address "
- "%2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x "
- "is not authorized\n",
- card->dev->dev_addr[0], card->dev->dev_addr[1],
- card->dev->dev_addr[2], card->dev->dev_addr[3],
- card->dev->dev_addr[4], card->dev->dev_addr[5]);
+ "MAC address %pM is not authorized\n",
+ card->dev->dev_addr);
break;
default:
break;
@@ -512,12 +504,8 @@ static int qeth_l2_send_setmac_cb(struct qeth_card *card,
memcpy(card->dev->dev_addr, cmd->data.setdelmac.mac,
OSA_ADDR_LEN);
dev_info(&card->gdev->dev,
- "MAC address %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x "
- "successfully registered on device %s\n",
- card->dev->dev_addr[0], card->dev->dev_addr[1],
- card->dev->dev_addr[2], card->dev->dev_addr[3],
- card->dev->dev_addr[4], card->dev->dev_addr[5],
- card->dev->name);
+ "MAC address %pM successfully registered on device %s\n",
+ card->dev->dev_addr, card->dev->name);
}
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/s390/net/qeth_l2_main.c: use %pM to shown MAC address
2009-12-28 23:39 [PATCH] drivers/s390/net/qeth_l2_main.c: use %pM to shown MAC address H Hartley Sweeten
@ 2009-12-30 17:16 ` David Miller
2009-12-30 17:39 ` H Hartley Sweeten
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-12-30 17:16 UTC (permalink / raw)
To: hartleys; +Cc: linux-kernel, netdev, linux-s390, blaschka
From: "H Hartley Sweeten" <hartleys@visionengravers.com>
Date: Mon, 28 Dec 2009 18:39:26 -0500
> Use the %pM kernel extension to display the MAC address.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drivers/s390/net/qeth_l2_main.c: use %pM to shown MAC address
2009-12-30 17:16 ` David Miller
@ 2009-12-30 17:39 ` H Hartley Sweeten
0 siblings, 0 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2009-12-30 17:39 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev, linux-s390, blaschka
On Wednesday, December 30, 2009 10:17 AM, wrote:
> From: "H Hartley Sweeten" <hartleys@visionengravers.com>
> Date: Mon, 28 Dec 2009 18:39:26 -0500
>
>> Use the %pM kernel extension to display the MAC address.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> Applied.
Thanks for this one and the others.
Hartley
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-30 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-28 23:39 [PATCH] drivers/s390/net/qeth_l2_main.c: use %pM to shown MAC address H Hartley Sweeten
2009-12-30 17:16 ` David Miller
2009-12-30 17:39 ` H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).