* RE: [patch] noapic should depend on ioapic config not local
@ 2003-08-23 1:26 Brown, Len
0 siblings, 0 replies; 6+ messages in thread
From: Brown, Len @ 2003-08-23 1:26 UTC (permalink / raw)
To: Nakajima, Jun, Jeff Garzik, Ingo Oeser; +Cc: linux-kernel
Yes, Marcelo pulled the fix for this into 2.4.22 from the acpi tree this
morning.
Let me know if you have any problems with it going forward.
Thanks,
-Len
> -----Original Message-----
> From: Nakajima, Jun
> Sent: Friday, August 22, 2003 7:12 PM
> To: Jeff Garzik; Ingo Oeser
> Cc: linux-kernel@vger.kernel.org
> Subject: RE: [patch] noapic should depend on ioapic config not local
>
>
> Looks like it's still ignored there (in BK). We did not realize the
> problem we worked on ACPI problems. We'll look at the problem.
>
> Thanks,
> Jun
>
> > -----Original Message-----
> > From: Jeff Garzik [mailto:jgarzik@pobox.com]
> > Sent: Friday, August 22, 2003 8:27 AM
> > To: Ingo Oeser
> > Cc: linux-kernel@vger.kernel.org
> > Subject: Re: [patch] noapic should depend on ioapic config not local
> >
> > On Fri, Aug 22, 2003 at 11:09:20AM +0200, Ingo Oeser wrote:
> > > On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> > > > Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
> > >
> > > Does this also apply to 2.4.22-rc2?
> > >
> > > I must use noapic on my system and 2.4.22 does ignore it, while
> > > 2.4.21 doesn't.
> >
> > Marcelo just pulled a bunch of ACPI fixes, so I would check
> the latest
> > BK, or wait for tonight's BK snapshot.
> >
> > So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have
> taken
> > care of it already.
> >
> > Jeff
> >
> >
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [patch] noapic should depend on ioapic config not local
@ 2003-08-23 1:45 Nakajima, Jun
0 siblings, 0 replies; 6+ messages in thread
From: Nakajima, Jun @ 2003-08-23 1:45 UTC (permalink / raw)
To: Brown, Len, Jeff Garzik, Ingo Oeser; +Cc: linux-kernel
Actually, it was a typo, "noapci" vs. "noacpi" :-<
"noapic" was recognized there ("noacpi" was not, we need to specify like
"pci=noacpi"), and I/O APIC(s) were correctly ignored (w/ ACPI or w/o
ACPI).
Thanks,
Jun
> -----Original Message-----
> From: Brown, Len
> Sent: Friday, August 22, 2003 6:26 PM
> To: Nakajima, Jun; Jeff Garzik; Ingo Oeser
> Cc: linux-kernel@vger.kernel.org
> Subject: RE: [patch] noapic should depend on ioapic config not local
>
> Yes, Marcelo pulled the fix for this into 2.4.22 from the acpi tree
this
> morning.
> Let me know if you have any problems with it going forward.
>
> Thanks,
> -Len
>
>
> > -----Original Message-----
> > From: Nakajima, Jun
> > Sent: Friday, August 22, 2003 7:12 PM
> > To: Jeff Garzik; Ingo Oeser
> > Cc: linux-kernel@vger.kernel.org
> > Subject: RE: [patch] noapic should depend on ioapic config not local
> >
> >
> > Looks like it's still ignored there (in BK). We did not realize the
> > problem we worked on ACPI problems. We'll look at the problem.
> >
> > Thanks,
> > Jun
> >
> > > -----Original Message-----
> > > From: Jeff Garzik [mailto:jgarzik@pobox.com]
> > > Sent: Friday, August 22, 2003 8:27 AM
> > > To: Ingo Oeser
> > > Cc: linux-kernel@vger.kernel.org
> > > Subject: Re: [patch] noapic should depend on ioapic config not
local
> > >
> > > On Fri, Aug 22, 2003 at 11:09:20AM +0200, Ingo Oeser wrote:
> > > > On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> > > > > Zwane's comment was correct, it needs to be
CONFIG_X86_IO_APIC.
> > > >
> > > > Does this also apply to 2.4.22-rc2?
> > > >
> > > > I must use noapic on my system and 2.4.22 does ignore it, while
> > > > 2.4.21 doesn't.
> > >
> > > Marcelo just pulled a bunch of ACPI fixes, so I would check
> > the latest
> > > BK, or wait for tonight's BK snapshot.
> > >
> > > So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have
> > taken
> > > care of it already.
> > >
> > > Jeff
> > >
> > >
> > >
> > > -
> > > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at http://www.tux.org/lkml/
> > -
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
> -
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [patch] noapic should depend on ioapic config not local
@ 2003-08-22 23:12 Nakajima, Jun
0 siblings, 0 replies; 6+ messages in thread
From: Nakajima, Jun @ 2003-08-22 23:12 UTC (permalink / raw)
To: Jeff Garzik, Ingo Oeser; +Cc: linux-kernel
Looks like it's still ignored there (in BK). We did not realize the
problem we worked on ACPI problems. We'll look at the problem.
Thanks,
Jun
> -----Original Message-----
> From: Jeff Garzik [mailto:jgarzik@pobox.com]
> Sent: Friday, August 22, 2003 8:27 AM
> To: Ingo Oeser
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [patch] noapic should depend on ioapic config not local
>
> On Fri, Aug 22, 2003 at 11:09:20AM +0200, Ingo Oeser wrote:
> > On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> > > Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
> >
> > Does this also apply to 2.4.22-rc2?
> >
> > I must use noapic on my system and 2.4.22 does ignore it, while
> > 2.4.21 doesn't.
>
> Marcelo just pulled a bunch of ACPI fixes, so I would check the latest
> BK, or wait for tonight's BK snapshot.
>
> So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have
taken
> care of it already.
>
> Jeff
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] noapic should depend on ioapic config not local
2003-08-22 9:09 ` Ingo Oeser
@ 2003-08-22 15:27 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2003-08-22 15:27 UTC (permalink / raw)
To: Ingo Oeser; +Cc: linux-kernel
On Fri, Aug 22, 2003 at 11:09:20AM +0200, Ingo Oeser wrote:
> On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> > Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
>
> Does this also apply to 2.4.22-rc2?
>
> I must use noapic on my system and 2.4.22 does ignore it, while
> 2.4.21 doesn't.
Marcelo just pulled a bunch of ACPI fixes, so I would check the latest
BK, or wait for tonight's BK snapshot.
So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have taken
care of it already.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] noapic should depend on ioapic config not local
2003-08-21 5:21 Jeff Garzik
@ 2003-08-22 9:09 ` Ingo Oeser
2003-08-22 15:27 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Ingo Oeser @ 2003-08-22 9:09 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel
On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
Does this also apply to 2.4.22-rc2?
I must use noapic on my system and 2.4.22 does ignore it, while
2.4.21 doesn't.
Regards
Ingo Oeser
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch] noapic should depend on ioapic config not local
@ 2003-08-21 5:21 Jeff Garzik
2003-08-22 9:09 ` Ingo Oeser
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2003-08-21 5:21 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
IMO this stuff really wants to be moved to __setup(),
to clean up the ifdefs and modularize the code.
===== arch/i386/kernel/setup.c 1.93 vs edited =====
--- 1.93/arch/i386/kernel/setup.c Wed Aug 20 14:15:34 2003
+++ edited/arch/i386/kernel/setup.c Wed Aug 20 21:27:05 2003
@@ -543,12 +543,12 @@
if (!acpi_force) acpi_disabled = 1;
}
-#ifdef CONFIG_X86_LOCAL_APIC
+#ifdef CONFIG_X86_IO_APIC
/* disable IO-APIC */
else if (!memcmp(from, "noapic", 6)) {
skip_ioapic_setup = 1;
}
-#endif /* CONFIG_X86_LOCAL_APIC */
+#endif /* CONFIG_X86_IO_APIC */
#endif /* CONFIG_ACPI_BOOT */
/*
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-08-23 1:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-23 1:26 [patch] noapic should depend on ioapic config not local Brown, Len
-- strict thread matches above, loose matches on Subject: below --
2003-08-23 1:45 Nakajima, Jun
2003-08-22 23:12 Nakajima, Jun
2003-08-21 5:21 Jeff Garzik
2003-08-22 9:09 ` Ingo Oeser
2003-08-22 15:27 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).