* RE: [PATCH] remove bogus double softirq processing in cris
[not found] <BFECAF9E178F144FAEF2BF4CE739C66802055E59@exmail1.se.axis.com>
@ 2005-01-03 13:34 ` Mikael Starvik
0 siblings, 0 replies; 3+ messages in thread
From: Mikael Starvik @ 2005-01-03 13:34 UTC (permalink / raw)
To: 'Christoph Hellwig', Mikael Starvik, akpm; +Cc: linux-kernel
Go ahead and submit it. This was removed locally quite a while ago and I'm
rewriting the IRQ handling to use the new consolidate IRQ stuff in 2.6.10 as
I write this. So don't bother that your patch breaks CRIS in the current 2.6
tree.
/Mikael
-----Original Message-----
From: Christoph Hellwig [mailto:hch@lst.de]
Sent: Monday, January 03, 2005 2:28 PM
To: Mikael Starvik; akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove bogus double softirq processing in cris
On Sun, Nov 14, 2004 at 11:43:28AM +0100, Christoph Hellwig wrote:
> I sent this out long ago already, but it's still not in:
>
> These days irq_exit does all softirq processing, so there's no need to
> call do_softirq again in cris.
>
> Also is there any chance you could switch cris to use the new
> CONFIG_GENERIC_HARDIRQS code in 2.6.10-rc that would replace most of
> arch/cris/kernel/irq.c with generic code from kernel/irq/* ?
ping? the broken code this patch removes really gets in the way of the
softirq_pending() removal I plan to submit soon..
--- 1.17/arch/cris/kernel/irq.c 2004-10-20 10:37:14 +02:00
+++ edited/arch/cris/kernel/irq.c 2004-11-14 11:39:14 +01:00
@@ -158,11 +158,6 @@ asmlinkage void do_IRQ(int irq, struct p
local_irq_disable();
}
irq_exit();
-
- if (softirq_pending(cpu))
- do_softirq();
-
- /* unmasking and bottom half handling is done magically for us. */
}
/* this function links in a handler into the chain of handlers for the
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] remove bogus double softirq processing in cris
@ 2004-11-14 10:43 Christoph Hellwig
2005-01-03 13:27 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2004-11-14 10:43 UTC (permalink / raw)
To: mikael.starvik; +Cc: linux-kernel
I sent this out long ago already, but it's still not in:
These days irq_exit does all softirq processing, so there's no need to
call do_softirq again in cris.
Also is there any chance you could switch cris to use the new
CONFIG_GENERIC_HARDIRQS code in 2.6.10-rc that would replace most of
arch/cris/kernel/irq.c with generic code from kernel/irq/* ?
--- 1.17/arch/cris/kernel/irq.c 2004-10-20 10:37:14 +02:00
+++ edited/arch/cris/kernel/irq.c 2004-11-14 11:39:14 +01:00
@@ -158,11 +158,6 @@ asmlinkage void do_IRQ(int irq, struct p
local_irq_disable();
}
irq_exit();
-
- if (softirq_pending(cpu))
- do_softirq();
-
- /* unmasking and bottom half handling is done magically for us. */
}
/* this function links in a handler into the chain of handlers for the
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove bogus double softirq processing in cris
2004-11-14 10:43 Christoph Hellwig
@ 2005-01-03 13:27 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2005-01-03 13:27 UTC (permalink / raw)
To: mikael.starvik, akpm; +Cc: linux-kernel
On Sun, Nov 14, 2004 at 11:43:28AM +0100, Christoph Hellwig wrote:
> I sent this out long ago already, but it's still not in:
>
> These days irq_exit does all softirq processing, so there's no need to
> call do_softirq again in cris.
>
> Also is there any chance you could switch cris to use the new
> CONFIG_GENERIC_HARDIRQS code in 2.6.10-rc that would replace most of
> arch/cris/kernel/irq.c with generic code from kernel/irq/* ?
ping? the broken code this patch removes really gets in the way of the
softirq_pending() removal I plan to submit soon..
--- 1.17/arch/cris/kernel/irq.c 2004-10-20 10:37:14 +02:00
+++ edited/arch/cris/kernel/irq.c 2004-11-14 11:39:14 +01:00
@@ -158,11 +158,6 @@ asmlinkage void do_IRQ(int irq, struct p
local_irq_disable();
}
irq_exit();
-
- if (softirq_pending(cpu))
- do_softirq();
-
- /* unmasking and bottom half handling is done magically for us. */
}
/* this function links in a handler into the chain of handlers for the
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-03 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <BFECAF9E178F144FAEF2BF4CE739C66802055E59@exmail1.se.axis.com>
2005-01-03 13:34 ` [PATCH] remove bogus double softirq processing in cris Mikael Starvik
2004-11-14 10:43 Christoph Hellwig
2005-01-03 13:27 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).