RE: [PATCH] x86: Prefer MWAIT over HALT on AMD processors

From: "Limonciello, Mario" <Mario.Limonciello@amd.com>
To: Dave Hansen <dave.hansen@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Karny, Wyes" <Wyes.Karny@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Carroll, Lewis" <Lewis.Carroll@amd.com>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Narayan, Ananth" <Ananth.Narayan@amd.com>,
	"Rao, Bharata Bhasker" <bharata@amd.com>,
	"len.brown@intel.com" <len.brown@intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"metze@samba.org" <metze@samba.org>,
	"zhengqi.arch@bytedance.com" <zhengqi.arch@bytedance.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>
Subject: RE: [PATCH] x86: Prefer MWAIT over HALT on AMD processors
Date: Tue, 5 Apr 2022 20:40:16 +0000	[thread overview]
Message-ID: <BL1PR12MB515702C06E483DF4EB78A7ADE2E49@BL1PR12MB5157.namprd12.prod.outlook.com> (raw)
In-Reply-To: <5873a444-bb32-f0d5-27f1-173f469baf21@intel.com>

[Public]

> -----Original Message-----
> From: Dave Hansen <dave.hansen@intel.com>
> Sent: Tuesday, April 5, 2022 10:47
> To: Limonciello, Mario <Mario.Limonciello@amd.com>; Peter Zijlstra
> <peterz@infradead.org>; Karny, Wyes <Wyes.Karny@amd.com>
> Cc: linux-kernel@vger.kernel.org; Carroll, Lewis <Lewis.Carroll@amd.com>;
> Shenoy, Gautham Ranjal <gautham.shenoy@amd.com>; Narayan, Ananth
> <Ananth.Narayan@amd.com>; Rao, Bharata Bhasker <bharata@amd.com>;
> len.brown@intel.com; x86@kernel.org; tglx@linutronix.de;
> mingo@redhat.com; bp@alien8.de; dave.hansen@linux.intel.com;
> hpa@zytor.com; chang.seok.bae@intel.com; keescook@chromium.org;
> metze@samba.org; zhengqi.arch@bytedance.com; mark.rutland@arm.com
> Subject: Re: [PATCH] x86: Prefer MWAIT over HALT on AMD processors
> 
> On 4/5/22 08:34, Limonciello, Mario wrote:
> >>>         if (!static_cpu_has(X86_FEATURE_ZEN)) {
> >>>                 msr |= ssbd_tif_to_amd_ls_cfg(tifn);
> >>>                 wrmsrl(MSR_AMD64_LS_CFG, msr);
> >>>                 return;
> >>>         }
> >> This seem _bit_ at odds with the commit message (and the AMD SSBD
> >> whitepaper):
> >>
> >>>     Add the necessary synchronization logic for AMD family 17H.
> >> So, is X86_FEATURE_ZEN for family==0x17, or family>=0x17?
> > There are Zen family CPUs and APUs from family 0x19.  Perhaps at the
> > time of the whitepaper there weren't yet though.
> 
> Is this a gap in the documentation, then?  Is there some documentation
> of the availability of SSBD mitigations on family 0x19?

It looks like a misinterpretation of the document.

Notice it mentions in Non-architectural MSRs explicitly:

"some models of family 17h have logic that allow loads to bypass older stores 
but lack the architectural SPEC_CTRL or VIRT_SPEC_CTR"

But that is not for all family 17h nor for family 19h.  You can see earlier in
the document the method to detect presence for SSBD which applies to the
rest of 17h and 19h.  That code in amd_set_core_ssb_state is only used for
one of the mitigation codepaths without MSR support, not for all Zen CPUs.

> 
> Anyway, back to MWAIT...  It would be really great to include the
> assumptions about what X86_FEATURE_ZEN means in the context of this
> patch.  Does this patch *really* mean "Zen microarchitecture" only?