* [PATCH] staging: lustre: lustre: libcfs: define symbols as static
@ 2015-02-05 13:24 Chen Weixiang
0 siblings, 0 replies; 2+ messages in thread
From: Chen Weixiang @ 2015-02-05 13:24 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, Peng Tao,
Hema Prathaban, Julia Lawall, Luca Ceresoli, Chen Weixiang,
Joe Perches, Greg Donald
Cc: HPDD-discuss, devel, linux-kernel
This patch fixes the following warning using sparse
- warning: symbol 'libcfs_debug_mb' was not declared. Should it be
static?
- warning: symbol 'portal_enter_debugger' was not declared. Should
it be static?
Signed-off-by: Chen Weixiang <weixiangx.chen@outlook.com>
---
drivers/staging/lustre/lustre/libcfs/debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c b/drivers/staging/lustre/lustre/libcfs/debug.c
index 7170088..76c62e8 100644
--- a/drivers/staging/lustre/lustre/libcfs/debug.c
+++ b/drivers/staging/lustre/lustre/libcfs/debug.c
@@ -57,7 +57,7 @@ module_param(libcfs_debug, int, 0644);
MODULE_PARM_DESC(libcfs_debug, "Lustre kernel debug mask");
EXPORT_SYMBOL(libcfs_debug);
-unsigned int libcfs_debug_mb = 0;
+static unsigned int libcfs_debug_mb;
module_param(libcfs_debug_mb, uint, 0644);
MODULE_PARM_DESC(libcfs_debug_mb, "Total debug buffer size.");
EXPORT_SYMBOL(libcfs_debug_mb);
@@ -93,7 +93,7 @@ EXPORT_SYMBOL(libcfs_debug_binary);
unsigned int libcfs_stack = 3 * THREAD_SIZE / 4;
EXPORT_SYMBOL(libcfs_stack);
-unsigned int portal_enter_debugger;
+static unsigned int portal_enter_debugger;
EXPORT_SYMBOL(portal_enter_debugger);
unsigned int libcfs_catastrophe;
--
2.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] staging: lustre: lustre: libcfs: define symbols as static
@ 2015-02-05 13:13 Chen Weixiang
0 siblings, 0 replies; 2+ messages in thread
From: Chen Weixiang @ 2015-02-05 13:13 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, Peng Tao,
Hema Prathaban, Jiayi Ye, Rickard Strandqvist, Chen Weixiang,
Luca Ceresoli, Greg Donald, Joe Perches, Julia Lawall
Cc: HPDD-discuss, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 41 bytes --]
--
Best regards,
Chen Weixiang (Alex)
[-- Attachment #2: 0001-staging-lustre-lustre-libcfs-define-symbols-as-stati.patch --]
[-- Type: text/plain, Size: 1518 bytes --]
>From 8de8c7f65f4529e3febb384402344d062f64230b Mon Sep 17 00:00:00 2001
From: Chen Weixiang <weixiangx.chen@outlook.com>
Date: Thu, 5 Feb 2015 20:07:02 +0800
Subject: [PATCH] staging: lustre: lustre: libcfs: define symbols as static
This patch fixes the following warning using sparse
- warning: symbol 'libcfs_debug_mb' was not declared. Should it be
static?
- warning: symbol 'portal_enter_debugger' was not declared. Should
it be static?
Signed-off-by: Chen Weixiang <weixiangx.chen@outlook.com>
---
drivers/staging/lustre/lustre/libcfs/debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c b/drivers/staging/lustre/lustre/libcfs/debug.c
index 7170088..76c62e8 100644
--- a/drivers/staging/lustre/lustre/libcfs/debug.c
+++ b/drivers/staging/lustre/lustre/libcfs/debug.c
@@ -57,7 +57,7 @@ module_param(libcfs_debug, int, 0644);
MODULE_PARM_DESC(libcfs_debug, "Lustre kernel debug mask");
EXPORT_SYMBOL(libcfs_debug);
-unsigned int libcfs_debug_mb = 0;
+static unsigned int libcfs_debug_mb;
module_param(libcfs_debug_mb, uint, 0644);
MODULE_PARM_DESC(libcfs_debug_mb, "Total debug buffer size.");
EXPORT_SYMBOL(libcfs_debug_mb);
@@ -93,7 +93,7 @@ EXPORT_SYMBOL(libcfs_debug_binary);
unsigned int libcfs_stack = 3 * THREAD_SIZE / 4;
EXPORT_SYMBOL(libcfs_stack);
-unsigned int portal_enter_debugger;
+static unsigned int portal_enter_debugger;
EXPORT_SYMBOL(portal_enter_debugger);
unsigned int libcfs_catastrophe;
--
2.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-05 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 13:24 [PATCH] staging: lustre: lustre: libcfs: define symbols as static Chen Weixiang
-- strict thread matches above, loose matches on Subject: below --
2015-02-05 13:13 Chen Weixiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).