From: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
To: Borislav Petkov <bp@suse.de>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration
Date: Tue, 4 Apr 2017 13:34:42 +0000 [thread overview]
Message-ID: <BN6PR1201MB0131D65FA36398E1E2F93BE0F80B0@BN6PR1201MB0131.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20170328192303.a732usin3tq6els3@pd.tnic>
> -----Original Message-----
> From: Borislav Petkov [mailto:bp@suse.de]
> Sent: Tuesday, March 28, 2017 3:23 PM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: linux-edac@vger.kernel.org; Tony Luck <tony.luck@intel.com>;
> x86@kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration
>
> On Wed, Mar 22, 2017 at 02:29:31PM -0500, Yazen Ghannam wrote:
> > From: Yazen Ghannam <yazen.ghannam@amd.com>
> >
> > Scalable MCA systems have a new MCA_CONFIG register that we use to
> > configure each bank. We currently use this when we set up thresholding.
> > However, this is logically separate.
> >
> > Move setup of MCA_CONFIG into a separate function.
> >
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > ---
> > arch/x86/kernel/cpu/mcheck/mce_amd.c | 48
> > ++++++++++++++++++++----------------
> > 1 file changed, 27 insertions(+), 21 deletions(-)
>
> ...
>
> > /* cpu init entry point, called from mce.c with preempt off */ @@
> > -515,8 +519,10 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c)
> > int offset = -1;
> >
> > for (bank = 0; bank < mca_cfg.banks; ++bank) {
> > - if (mce_flags.smca)
> > + if (mce_flags.smca) {
> > get_smca_bank_info(bank);
> > + set_smca_config(bank);
>
> Or simply bundle those two which do something SMCA-aware per bank into a
> single:
>
> smca_configure(bank);
>
> which reads almost like a sentence.
>
I'd like to keep the functions separate since they're logically independent. I can
define something like smca_configure() as a wrapper function that can contain
current and future SMCA related functions. Is this okay?
Thanks,
Yazen
next prev parent reply other threads:[~2017-04-04 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 19:29 [PATCH 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers Yazen Ghannam
2017-03-22 19:29 ` [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration Yazen Ghannam
2017-03-28 19:23 ` Borislav Petkov
2017-04-04 13:34 ` Ghannam, Yazen [this message]
2017-04-04 13:45 ` Borislav Petkov
2017-04-04 14:37 ` Ghannam, Yazen
2017-04-04 15:00 ` Borislav Petkov
2017-04-04 15:08 ` Ghannam, Yazen
2017-03-27 17:27 ` [PATCH 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers Borislav Petkov
2017-04-04 13:30 ` Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR1201MB0131D65FA36398E1E2F93BE0F80B0@BN6PR1201MB0131.namprd12.prod.outlook.com \
--to=yazen.ghannam@amd.com \
--cc=bp@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).