* [PATCH v3 1/2] thermal: armada: fix register offsets for AXP [not found] <1575917171-11085-1-git-send-email-zhays@lexmark.com> @ 2019-12-09 18:55 ` Zak Hays 2019-12-16 8:07 ` Miquel Raynal [not found] ` <1575917171-11085-2-git-send-email-zhays@lexmark.com> 1 sibling, 1 reply; 4+ messages in thread From: Zak Hays @ 2019-12-09 18:55 UTC (permalink / raw) Cc: miquel.raynal, rui.zhang, Daniel Lezcano, amit.kucheria, linux-pm, linux-kernel As shown in its device tree, Armada XP has the control1 register at 0x184d0, not 0x182d0. Signed-off-by: Zachary Hays <zhays@lexmark.com> --- v2: update commit title and add "Signed-off-by" v3: resend for clarification --- drivers/thermal/armada_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index 709a22f455e9..88363812033c 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -578,7 +578,7 @@ static const struct armada_thermal_data armadaxp_data = { .coef_m = 10000000ULL, .coef_div = 13825, .syscon_status_off = 0xb0, - .syscon_control1_off = 0xd0, + .syscon_control1_off = 0x2d0, }; static const struct armada_thermal_data armada370_data = { -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/2] thermal: armada: fix register offsets for AXP 2019-12-09 18:55 ` [PATCH v3 1/2] thermal: armada: fix register offsets for AXP Zak Hays @ 2019-12-16 8:07 ` Miquel Raynal 0 siblings, 0 replies; 4+ messages in thread From: Miquel Raynal @ 2019-12-16 8:07 UTC (permalink / raw) To: Zak Hays; +Cc: rui.zhang, Daniel Lezcano, amit.kucheria, linux-pm, linux-kernel Hi Zak, Zak Hays <zak.hays@lexmark.com> wrote on Mon, 9 Dec 2019 18:55:51 +0000: > As shown in its device tree, Armada XP has the control1 register at > 0x184d0, not 0x182d0. > > Signed-off-by: Zachary Hays <zhays@lexmark.com> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1575917171-11085-2-git-send-email-zhays@lexmark.com>]
* [PATCH v3 2/2] thermal: armada: clear reset in armadaxp_init [not found] ` <1575917171-11085-2-git-send-email-zhays@lexmark.com> @ 2019-12-09 18:57 ` Zak Hays 2019-12-16 8:08 ` Miquel Raynal 0 siblings, 1 reply; 4+ messages in thread From: Zak Hays @ 2019-12-09 18:57 UTC (permalink / raw) Cc: miquel.raynal, rui.zhang, Daniel Lezcano, amit.kucheria, linux-pm, linux-kernel The reset bit needs to be cleared in the init sequence otherwise it holds the block in reset. Signed-off-by: Zachary Hays <zhays@lexmark.com> --- v2: update commit title and add "Signed-off-by" v3: resend for clarification --- drivers/thermal/armada_thermal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index 88363812033c..8c4d1244ee7a 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -155,6 +155,9 @@ static void armadaxp_init(struct platform_device *pdev, regmap_write(priv->syscon, data->syscon_control1_off, reg); + reg &= ~PMU_TDC0_SW_RST_MASK; + regmap_write(priv->syscon, data->syscon_control1_off, reg); + /* Enable the sensor */ regmap_read(priv->syscon, data->syscon_status_off, ®); reg &= ~PMU_TM_DISABLE_MASK; -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/2] thermal: armada: clear reset in armadaxp_init 2019-12-09 18:57 ` [PATCH v3 2/2] thermal: armada: clear reset in armadaxp_init Zak Hays @ 2019-12-16 8:08 ` Miquel Raynal 0 siblings, 0 replies; 4+ messages in thread From: Miquel Raynal @ 2019-12-16 8:08 UTC (permalink / raw) To: Zak Hays; +Cc: rui.zhang, Daniel Lezcano, amit.kucheria, linux-pm, linux-kernel Hi Zak, Zak Hays <zak.hays@lexmark.com> wrote on Mon, 9 Dec 2019 18:57:23 +0000: > The reset bit needs to be cleared in the init sequence otherwise it > holds the block in reset. > > Signed-off-by: Zachary Hays <zhays@lexmark.com> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-16 8:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1575917171-11085-1-git-send-email-zhays@lexmark.com>
2019-12-09 18:55 ` [PATCH v3 1/2] thermal: armada: fix register offsets for AXP Zak Hays
2019-12-16 8:07 ` Miquel Raynal
[not found] ` <1575917171-11085-2-git-send-email-zhays@lexmark.com>
2019-12-09 18:57 ` [PATCH v3 2/2] thermal: armada: clear reset in armadaxp_init Zak Hays
2019-12-16 8:08 ` Miquel Raynal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).