From: "Zhang, Tianfei" <tianfei.zhang@intel.com>
To: Mark Brown <broonie@kernel.org>,
"matthew.gerlach@linux.intel.com"
<matthew.gerlach@linux.intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wu, Hao" <hao.wu@intel.com>, "trix@redhat.com" <trix@redhat.com>,
"Xu, Yilun" <yilun.xu@intel.com>,
"Weight, Russell H" <russell.h.weight@intel.com>
Subject: RE: [PATCH v1] regmap: add generic indirect regmap support
Date: Wed, 8 Jun 2022 23:54:26 +0000 [thread overview]
Message-ID: <BN9PR11MB548315C03B09D841B6392E63E3A49@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YqB9O8HhZV2tXo8g@sirena.org.uk>
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Wednesday, June 8, 2022 6:43 PM
> To: matthew.gerlach@linux.intel.com
> Cc: Zhang, Tianfei <tianfei.zhang@intel.com>; gregkh@linuxfoundation.org;
> rafael@kernel.org; linux-kernel@vger.kernel.org; Wu, Hao
> <hao.wu@intel.com>; trix@redhat.com; Xu, Yilun <yilun.xu@intel.com>;
> Weight, Russell H <russell.h.weight@intel.com>
> Subject: Re: [PATCH v1] regmap: add generic indirect regmap support
>
> On Tue, Jun 07, 2022 at 05:27:38PM -0700, matthew.gerlach@linux.intel.com
> wrote:
> > On Tue, 7 Jun 2022, Mark Brown wrote:
> > > On Mon, Jun 06, 2022 at 09:37:55PM -0400, Tianfei Zhang wrote:
> > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> > > > This patch adds support for regmap APIs that are intended to be
> > > > used by the drivers of some devices which support generic indirect
> > > > register access, for example PMCI (Platform Management Control
> > > > Interface) device, HSSI (High Speed Serial Interface) device in FPGA.
>
> > > What is "generic indirect register access"? I'm not clear what this
> > > is intended to support...
>
> > "indirect register access" is a RTL design pattern we use in FPGAs
> > frequently. The design pattern involves a small number of registers
> > plus a little handshake code to access various register spaces inside
> > the FPGA fabric. The design pattern is "generic" in the sense that
> > the same small number of registers and handshake can be used with many
> > different IP components in the FPGA. Historically, the bit
> > definitions and handshaking was slightly different for each IP
> > component. This is an attempt at a consistent usage across IP components.
>
> > Would a different name help?
>
> This wouldn't address the major problem which is...
>
> > > > + writel(0, ctx->base + INDIRECT_CMD_OFF);
> > > > + ret = readl_poll_timeout((ctx->base + INDIRECT_CMD_OFF), cmd,
> > > > + (!cmd), INDIRECT_INT_US,
> INDIRECT_TIMEOUT_US);
> > > > + if (ret)
> > > > + dev_err(ctx->dev, "%s timed out on clearing cmd 0x%xn",
> > > > +__func__, cmd);
>
> > > ...and this doesn't look particularly generic, it looks like it's
> > > for some particular controller/bridge?
>
> ...that this appears to be entirely specific to some particular device, it's got
> things like hard coded register addresses and timeouts which mean it can't be
> reused.
Yet, this is a register access hardware controller/bridge widely used in FPGA IP blocks, like PMCI, HSSI.
How about we change the patch title like this:
regmap: add indirect register controller support
next prev parent reply other threads:[~2022-06-08 23:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 1:37 [PATCH v1] regmap: add generic indirect regmap support Tianfei Zhang
2022-06-07 4:50 ` Greg KH
2022-06-07 5:57 ` Zhang, Tianfei
2022-06-07 13:15 ` Mark Brown
2022-06-08 0:27 ` matthew.gerlach
2022-06-08 10:43 ` Mark Brown
2022-06-08 23:54 ` Zhang, Tianfei [this message]
2022-06-09 10:14 ` Mark Brown
2022-06-10 0:30 ` matthew.gerlach
2022-06-10 11:59 ` Mark Brown
2022-08-09 17:06 ` Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB548315C03B09D841B6392E63E3A49@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=tianfei.zhang@intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=rafael@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).