From: Mark Brown <broonie@kernel.org>
To: "Zhang, Tianfei" <tianfei.zhang@intel.com>
Cc: "matthew.gerlach@linux.intel.com"
<matthew.gerlach@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wu, Hao" <hao.wu@intel.com>, "trix@redhat.com" <trix@redhat.com>,
"Xu, Yilun" <yilun.xu@intel.com>,
"Weight, Russell H" <russell.h.weight@intel.com>
Subject: Re: [PATCH v1] regmap: add generic indirect regmap support
Date: Thu, 9 Jun 2022 11:14:18 +0100 [thread overview]
Message-ID: <YqHH+oX/90KXv8dN@sirena.org.uk> (raw)
In-Reply-To: <BN9PR11MB548315C03B09D841B6392E63E3A49@BN9PR11MB5483.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
On Wed, Jun 08, 2022 at 11:54:26PM +0000, Zhang, Tianfei wrote:
> > > Would a different name help?
> >
> > This wouldn't address the major problem which is...
> >
> > > > > + writel(0, ctx->base + INDIRECT_CMD_OFF);
> > > > > + ret = readl_poll_timeout((ctx->base + INDIRECT_CMD_OFF), cmd,
> > > > > + (!cmd), INDIRECT_INT_US,
> > INDIRECT_TIMEOUT_US);
> > > > > + if (ret)
> > > > > + dev_err(ctx->dev, "%s timed out on clearing cmd 0x%xn",
> > > > > +__func__, cmd);
> >
> > > > ...and this doesn't look particularly generic, it looks like it's
> > > > for some particular controller/bridge?
> >
> > ...that this appears to be entirely specific to some particular device, it's got
> > things like hard coded register addresses and timeouts which mean it can't be
> > reused.
>
> Yet, this is a register access hardware controller/bridge widely used in FPGA IP blocks, like PMCI, HSSI.
> How about we change the patch title like this:
> regmap: add indirect register controller support
No, please enage with my feedback above.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-09 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 1:37 [PATCH v1] regmap: add generic indirect regmap support Tianfei Zhang
2022-06-07 4:50 ` Greg KH
2022-06-07 5:57 ` Zhang, Tianfei
2022-06-07 13:15 ` Mark Brown
2022-06-08 0:27 ` matthew.gerlach
2022-06-08 10:43 ` Mark Brown
2022-06-08 23:54 ` Zhang, Tianfei
2022-06-09 10:14 ` Mark Brown [this message]
2022-06-10 0:30 ` matthew.gerlach
2022-06-10 11:59 ` Mark Brown
2022-08-09 17:06 ` Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqHH+oX/90KXv8dN@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=rafael@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).