From: Lijun Pan <Lijun.Pan@freescale.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hamciuc Bogdan <bhamciu1@freescale.com>,
Sharma Bhupesh <bhupesh.sharma@freescale.com>,
Jose Rivera <German.Rivera@freescale.com>,
"agraf@suse.de" <agraf@suse.de>,
Stuart Yoder <stuart.yoder@freescale.com>,
Erez Nir <nir.erez@freescale.com>,
Katz Itai <itai.katz@freescale.com>,
Scott Wood <scottwood@freescale.com>,
Li Leo <LeoLi@freescale.com>,
Marginean Alexandru <R89243@freescale.com>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
Richard Schmitt <richard.schmitt@freescale.com>
Subject: RE: [PATCH 4/5] staging: fsl-mc: bus rescan attribute to sync kernel with MC
Date: Thu, 29 Oct 2015 17:13:16 +0000 [thread overview]
Message-ID: <BY1PR03MB14525BA21E8FD3E6B9111D10FC200@BY1PR03MB1452.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20151027053939.GA22784@kroah.com>
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, October 27, 2015 12:40 AM
> To: Pan Lijun-B44306 <Lijun.Pan@freescale.com>
> Cc: arnd@arndb.de; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org; Hamciuc Bogdan-BHAMCIU1
> <bhamciu1@freescale.com>; Sharma Bhupesh-B45370
> <bhupesh.sharma@freescale.com>; Rivera Jose-B46482
> <German.Rivera@freescale.com>; agraf@suse.de; Yoder Stuart-B08248
> <stuart.yoder@freescale.com>; Erez Nir-RM30794 <nir.erez@freescale.com>;
> katz Itai-RM05202 <itai.katz@freescale.com>; Wood Scott-B07421
> <scottwood@freescale.com>; Li Yang-Leo-R58472 <LeoLi@freescale.com>;
> Marginean Alexandru-R89243 <R89243@freescale.com>;
> dan.carpenter@oracle.com; Schmitt Richard-B43082
> <richard.schmitt@freescale.com>
> Subject: Re: [PATCH 4/5] staging: fsl-mc: bus rescan attribute to sync kernel
> with MC
>
> On Sun, Oct 25, 2015 at 05:41:22PM -0500, Lijun Pan wrote:
> > Introduce the rescan attribute as a bus attribute to synchronize the
> > fsl-mc bus objects and the MC firmware.
> >
> > To rescan the fsl-mc bus, e.g.,
> > echo 1 > /sys/bus/fsl-mc/rescan
> >
> > Signed-off-by: Lijun Pan <Lijun.Pan@freescale.com>
> > ---
> > drivers/staging/fsl-mc/bus/mc-bus.c | 46
> > +++++++++++++++++++++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> >
> > diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
> > b/drivers/staging/fsl-mc/bus/mc-bus.c
> > index 33a56ad..f1baad7 100644
> > --- a/drivers/staging/fsl-mc/bus/mc-bus.c
> > +++ b/drivers/staging/fsl-mc/bus/mc-bus.c
> > @@ -144,11 +144,57 @@ static const struct attribute_group
> *fsl_mc_dev_groups[] = {
> > NULL,
> > };
> >
> > +static int scan_fsl_mc_bus(struct device *dev, void *data) {
> > + struct fsl_mc_device *root_mc_dev;
> > + struct fsl_mc_bus *root_mc_bus;
> > +
> > + if (is_root_dprc(dev)) {
> > + root_mc_dev = to_fsl_mc_device(dev);
> > + root_mc_bus = to_fsl_mc_bus(root_mc_dev);
> > + mutex_lock(&root_mc_bus->scan_mutex);
> > + dprc_scan_objects(root_mc_dev);
> > + mutex_unlock(&root_mc_bus->scan_mutex);
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static ssize_t bus_rescan_store(struct bus_type *bus,
> > + const char *buf, size_t count) {
> > + unsigned long val;
> > +
> > + if (kstrtoul(buf, 0, &val) < 0)
> > + return -EINVAL;
> > +
> > + if (val)
> > + bus_for_each_dev(bus, NULL, NULL, scan_fsl_mc_bus);
> > +
> > + return count;
> > +}
> > +static BUS_ATTR(rescan, (S_IWUSR|S_IWGRP), NULL, bus_rescan_store);
> > +
> > +static struct attribute *fsl_mc_bus_attrs[] = {
> > + &bus_attr_rescan.attr,
> > + NULL,
> > +};
> > +
> > +static const struct attribute_group fsl_mc_bus_group = {
> > + .attrs = fsl_mc_bus_attrs,
> > +};
> > +
> > +static const struct attribute_group *fsl_mc_bus_groups[] = {
> > + &fsl_mc_bus_group,
> > + NULL,
> > +};
> > +
> > struct bus_type fsl_mc_bus_type = {
> > .name = "fsl-mc",
> > .match = fsl_mc_bus_match,
> > .uevent = fsl_mc_bus_uevent,
> > .dev_groups = fsl_mc_dev_groups,
> > + .bus_groups = fsl_mc_bus_groups,
> > };
> > EXPORT_SYMBOL_GPL(fsl_mc_bus_type);
>
> No documentation update as well?
Hi Greg,
Are you saying something like adding
Documentation/ABI/testing/sysfs-bus-fsl-mc? For the fsl-mc bus
Documentation/ABI/testing/sysfs-devices-dprc? For the dprc device?
Or
drivers/staging/fsl-mc/[README.txt | TODO]?
Thanks
Lijun
next prev parent reply other threads:[~2015-10-29 17:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 22:41 [PATCH 0/5] Management Complex restool driver Lijun Pan
2015-10-25 22:41 ` [PATCH 1/5] staging: fsl-mc: section mismatch bug fix Lijun Pan
2015-10-25 22:41 ` [PATCH 2/5] staging: fsl-mc: define a macro to differentiate root dprc Lijun Pan
2015-10-26 0:12 ` Greg KH
2015-10-26 16:02 ` Lijun Pan
2015-10-25 22:41 ` [PATCH 3/5] staging: fsl-mc: root dprc rescan attribute to sync kernel with MC Lijun Pan
2015-10-25 22:41 ` [PATCH 4/5] staging: fsl-mc: bus " Lijun Pan
2015-10-27 5:39 ` Greg KH
2015-10-29 17:13 ` Lijun Pan [this message]
2015-10-25 22:41 ` [PATCH 5/5] staging: fsl-mc: Management Complex restool driver Lijun Pan
2015-10-26 6:20 ` Dan Carpenter
2015-10-26 16:01 ` Lijun Pan
2015-10-26 15:52 ` Stuart Yoder
2015-10-27 2:11 ` Stuart Yoder
2015-10-27 5:16 ` Scott Wood
2015-10-29 23:54 ` Lijun Pan
2015-10-30 16:43 ` Lijun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY1PR03MB14525BA21E8FD3E6B9111D10FC200@BY1PR03MB1452.namprd03.prod.outlook.com \
--to=lijun.pan@freescale.com \
--cc=German.Rivera@freescale.com \
--cc=LeoLi@freescale.com \
--cc=R89243@freescale.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bhamciu1@freescale.com \
--cc=bhupesh.sharma@freescale.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=itai.katz@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nir.erez@freescale.com \
--cc=richard.schmitt@freescale.com \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).